Skip to content

Commit ffcb251

Browse files
author
Chris Elion
authored
Add ObservationType to analytics ObservationSpec (#5218)
1 parent 7281dc1 commit ffcb251

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

com.unity.ml-agents/Runtime/Analytics/Events.cs

+2
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ internal struct EventObservationSpec
9797
public string SensorName;
9898
public string CompressionType;
9999
public int BuiltInSensorType;
100+
public int ObservationType;
100101
public EventObservationDimensionInfo[] DimensionInfos;
101102

102103
public static EventObservationSpec FromSensor(ISensor sensor)
@@ -119,6 +120,7 @@ public static EventObservationSpec FromSensor(ISensor sensor)
119120
SensorName = sensor.GetName(),
120121
CompressionType = sensor.GetCompressionSpec().SensorCompressionType.ToString(),
121122
BuiltInSensorType = (int)builtInSensorType,
123+
ObservationType = (int)obsSpec.ObservationType,
122124
DimensionInfos = dimInfos,
123125
};
124126
}

com.unity.ml-agents/Tests/Editor/Analytics/InferenceAnalyticsTests.cs

+1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public void TestModelEvent()
6565
Assert.AreEqual(2, continuousEvent.ObservationSpecs.Count);
6666
Assert.AreEqual(3, continuousEvent.ObservationSpecs[0].DimensionInfos.Length);
6767
Assert.AreEqual(20, continuousEvent.ObservationSpecs[0].DimensionInfos[0].Size);
68+
Assert.AreEqual(0, continuousEvent.ObservationSpecs[0].ObservationType);
6869
Assert.AreEqual((int)DimensionProperty.TranslationalEquivariance, continuousEvent.ObservationSpecs[0].DimensionInfos[0].Flags);
6970
Assert.AreEqual((int)DimensionProperty.None, continuousEvent.ObservationSpecs[0].DimensionInfos[2].Flags);
7071
Assert.AreEqual("None", continuousEvent.ObservationSpecs[0].CompressionType);

com.unity.ml-agents/Tests/Editor/Analytics/TrainingAnalyticsTest.cs

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public void TestRemotePolicyEvent()
4141
Assert.AreEqual(2, remotePolicyEvent.ObservationSpecs.Count);
4242
Assert.AreEqual(3, remotePolicyEvent.ObservationSpecs[0].DimensionInfos.Length);
4343
Assert.AreEqual(20, remotePolicyEvent.ObservationSpecs[0].DimensionInfos[0].Size);
44+
Assert.AreEqual(0, remotePolicyEvent.ObservationSpecs[0].ObservationType);
4445
Assert.AreEqual("None", remotePolicyEvent.ObservationSpecs[0].CompressionType);
4546
Assert.AreEqual(Test3DSensor.k_BuiltInSensorType, remotePolicyEvent.ObservationSpecs[0].BuiltInSensorType);
4647

0 commit comments

Comments
 (0)