Skip to content

Commit ac3926d

Browse files
committed
Make FacetedPlotPropsWithRef
1 parent fc75038 commit ac3926d

8 files changed

+20
-15
lines changed

src/plots/FacetedPlot.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ export interface FacetedPlotProps<D, P extends PlotProps<D>> {
3232
checkedLegendItems?: string[];
3333
}
3434

35+
export interface FacetedPlotPropsWithRef<D, P extends PlotProps<D>>
36+
extends FacetedPlotProps<D, P> {
37+
facetedPlotRef?: Ref<FacetedPlotRef>;
38+
}
39+
3540
function renderFacetedPlot<D, P extends PlotProps<D>>(
3641
props: FacetedPlotProps<D, P>,
3742
ref: Ref<FacetedPlotRef>
@@ -160,7 +165,7 @@ const makeFacetedPlotComponent = memoize(function <D, P extends PlotProps<D>>(
160165
});
161166

162167
export default function FacetedPlot<D, P extends PlotProps<D>>(
163-
props: FacetedPlotProps<D, P> & { facetedPlotRef?: Ref<FacetedPlotRef> }
168+
props: FacetedPlotPropsWithRef<D, P>
164169
) {
165170
const FacetedPlotComponent = makeFacetedPlotComponent<D, P>(props.component);
166171

src/plots/facetedPlots/FacetedBarplot.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Barplot, { BarplotProps } from '../Barplot';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { BarplotData } from '../../types/plots';
44

55
export const defaultContainerStyles: BarplotProps['containerStyles'] = {
@@ -18,7 +18,7 @@ export const defaultSpacingOptions: BarplotProps['spacingOptions'] = {
1818
};
1919

2020
type FacetedBarplotProps = Omit<
21-
FacetedPlotProps<BarplotData, BarplotProps>,
21+
FacetedPlotPropsWithRef<BarplotData, BarplotProps>,
2222
'component'
2323
>;
2424

src/plots/facetedPlots/FacetedBoxplot.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Boxplot, { BoxplotProps } from '../Boxplot';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { BoxplotData } from '../../types/plots';
44

55
export const defaultContainerStyles: BoxplotProps['containerStyles'] = {
@@ -18,7 +18,7 @@ export const defaultSpacingOptions: BoxplotProps['spacingOptions'] = {
1818
};
1919

2020
type FacetedBoxplotProps = Omit<
21-
FacetedPlotProps<BoxplotData, BoxplotProps>,
21+
FacetedPlotPropsWithRef<BoxplotData, BoxplotProps>,
2222
'component'
2323
>;
2424

src/plots/facetedPlots/FacetedHeatmap.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Heatmap, { HeatmapProps } from '../Heatmap';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { HeatmapData } from '../../types/plots';
44

55
export const defaultContainerStyles: HeatmapProps['containerStyles'] = {
@@ -18,7 +18,7 @@ export const defaultSpacingOptions: HeatmapProps['spacingOptions'] = {
1818
};
1919

2020
type FacetedHeatmapProps = Omit<
21-
FacetedPlotProps<HeatmapData, HeatmapProps>,
21+
FacetedPlotPropsWithRef<HeatmapData, HeatmapProps>,
2222
'component'
2323
>;
2424

src/plots/facetedPlots/FacetedHistogram.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Histogram, { HistogramProps } from '../Histogram';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { HistogramData } from '../../types/plots';
44

55
export const defaultContainerStyles: HistogramProps['containerStyles'] = {
@@ -19,7 +19,7 @@ export const defaultSpacingOptions: HistogramProps['spacingOptions'] = {
1919
};
2020

2121
type FacetedHistogramProps = Omit<
22-
FacetedPlotProps<HistogramData, HistogramProps>,
22+
FacetedPlotPropsWithRef<HistogramData, HistogramProps>,
2323
'component'
2424
>;
2525

src/plots/facetedPlots/FacetedMosaicPlot.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import MosaicPlot, { MosaicPlotProps } from '../MosaicPlot';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { MosaicPlotData } from '../../types/plots';
44

55
export const defaultContainerStyles: MosaicPlotProps['containerStyles'] = {
@@ -18,7 +18,7 @@ export const defaultSpacingOptions: MosaicPlotProps['spacingOptions'] = {
1818
};
1919

2020
type FacetedMosaicPlotProps = Omit<
21-
FacetedPlotProps<MosaicPlotData, MosaicPlotProps>,
21+
FacetedPlotPropsWithRef<MosaicPlotData, MosaicPlotProps>,
2222
'component'
2323
>;
2424

src/plots/facetedPlots/FacetedPiePlot.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import PiePlot, { PiePlotProps } from '../PiePlot';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { PiePlotData } from '../../types/plots';
44
import { useCallback } from 'react';
55
import { select } from 'd3';
@@ -20,7 +20,7 @@ export const defaultSpacingOptions: PiePlotProps['spacingOptions'] = {
2020
};
2121

2222
type FacetedPiePlotProps = Omit<
23-
FacetedPlotProps<PiePlotData, PiePlotProps>,
23+
FacetedPlotPropsWithRef<PiePlotData, PiePlotProps>,
2424
'component'
2525
>;
2626

src/plots/facetedPlots/FacetedXYPlot.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XYPlot, { XYPlotProps } from '../XYPlot';
2-
import FacetedPlot, { FacetedPlotProps } from '../FacetedPlot';
2+
import FacetedPlot, { FacetedPlotPropsWithRef } from '../FacetedPlot';
33
import { XYPlotData } from '../../types/plots';
44

55
export const defaultContainerStyles: XYPlotProps['containerStyles'] = {
@@ -18,7 +18,7 @@ export const defaultSpacingOptions: XYPlotProps['spacingOptions'] = {
1818
};
1919

2020
type FacetedXYPlotProps = Omit<
21-
FacetedPlotProps<XYPlotData, XYPlotProps>,
21+
FacetedPlotPropsWithRef<XYPlotData, XYPlotProps>,
2222
'component'
2323
>;
2424

0 commit comments

Comments
 (0)