Skip to content

Consider greying-out text in legend for items not shown #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danicahelb opened this issue Oct 17, 2022 · 1 comment · May be fixed by VEuPathDB/web-components#401
Open

Consider greying-out text in legend for items not shown #1431

danicahelb opened this issue Oct 17, 2022 · 1 comment · May be fixed by VEuPathDB/web-components#401
Assignees
Labels
UX topic indicates the issue is paused for discussion in EDA UX meeting

Comments

@danicahelb
Copy link

Currently, overlay values that are filtered out of my subset show a grey check box but the text is still black. For example:
image

Also, when things like smoothed mean & 95% CI cannot be calculated, the legend shows a grey check box but the text is still black. For example:
image

I think we should consider greying out the text in addition to showing the grey check box for these items

@danicahelb danicahelb added the UX topic indicates the issue is paused for discussion in EDA UX meeting label Oct 17, 2022
@moontrip moontrip self-assigned this Oct 17, 2022
@moontrip moontrip linked a pull request Oct 24, 2022 that will close this issue
@moontrip moontrip linked a pull request Oct 24, 2022 that will close this issue
@moontrip
Copy link
Contributor

@danicahelb I have made a draft PR to address this at VEuPathDB/web-components#401 screenshots are attached as well. Will wait for the final decision.

@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX topic indicates the issue is paused for discussion in EDA UX meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants