Skip to content

Floating point textual representation grammar issues #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
verbessern opened this issue Apr 19, 2020 · 2 comments · Fixed by WebAssembly/spec#1178
Closed

Floating point textual representation grammar issues #1337

verbessern opened this issue Apr 19, 2020 · 2 comments · Fixed by WebAssembly/spec#1178

Comments

@verbessern
Copy link

verbessern commented Apr 19, 2020 •
edited
Loading

Hi there, I think that the grammar in section 6.3.2 is not as intended. It is not possible to have for example floating point frac as 1_2_3, because the grammar does not allow that, but only 1_23 or 12_3. For example the num in 6.3.1 allows this. The same is visible also in hexfrac.
@rossberg rossberg mentioned this issue Apr 20, 2020
Merged
@rossberg
Copy link
Member

rossberg commented Apr 20, 2020 •
edited
Loading

Indeed, the grammar is wrong. Thanks for spotting! Fix here.

Btw, issues like these would be more appropriately filed in the spec repo.

@verbessern
Copy link
Author

Welcome. Understood for the repo, I'm new in the hub, but I will be around for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[spec] Fix grammar for fractions WebAssembly/spec
2 participants
@rossberg @verbessern