MS Edge Release

 * fixed #221 through script creation via global document
 * fixed hyper.Component resulting in broken super() call

Author: Andrea Giammarchi

cjs/classes/Component.js

@@ -9,7 +9,9 @@ const { WeakMap } = require('../shared/poorlyfills.js');
 // The main difference is that declared components
 // will not automatically render on setState(...)
 // to simplify state handling on render.
-function Component() {}
+function Component() {
+  return this; // this is needed in Edge !!!
+}
 Object.defineProperty(exports, '__esModule', {value: true}).default = Component
 
 // Component is lazily setup because it needs

cjs/objects/Updates.js

@@ -9,7 +9,9 @@ const Path = (m => m.__esModule ? m.default : m)(require('./Path.js'));
 const Style = (m => m.__esModule ? m.default : m)(require('./Style.js'));
 const Intent = (m => m.__esModule ? m.default : m)(require('./Intent.js'));
 const domdiff = (m => m.__esModule ? m.default : m)(require('../shared/domdiff.js'));
-const { create: createElement, text } = require('../shared/easy-dom.js');
+// see /^script$/i.test(nodeName) bit down here
+// import { create as createElement, text } from '../shared/easy-dom.js';
+const { text } = require('../shared/easy-dom.js');
 const { Event, WeakSet, isArray, trim } = require('../shared/poorlyfills.js');
 const { createFragment, slice } = require('../shared/utils.js');
 
@@ -161,18 +163,29 @@ const findAttributes = (node, paths, parts) => {
   }
   const len = remove.length;
   for (let i = 0; i < len; i++) {
-    node.removeAttributeNode(remove[i]);
+    // Edge HTML bug #16878726
+    const attribute = remove[i];
+    if (/^id$/i.test(attribute.name))
+      node.removeAttribute(attribute.name);
+    // standard browsers would work just fine here
+    else
+      node.removeAttributeNode(remove[i]);
   }
 
   // This is a very specific Firefox/Safari issue
   // but since it should be a not so common pattern,
   // it's probably worth patching regardless.
   // Basically, scripts created through strings are death.
   // You need to create fresh new scripts instead.
-  // TODO: is there any other node that needs such nonsense ?
+  // TODO: is there any other node that needs such nonsense?
   const nodeName = node.nodeName;
   if (/^script$/i.test(nodeName)) {
-    const script = createElement(node, nodeName);
+    // this used to be like that
+    // const script = createElement(node, nodeName);
+    // then Edge arrived and decided that scripts created
+    // through template documents aren't worth executing
+    // so it became this ... hopefully it won't hurt in the wild
+    const script = document.createElement(nodeName);
     for (let i = 0; i < attributes.length; i++) {
       script.setAttributeNode(attributes[i].cloneNode(true));
     }

coverage/coverage.json

@@ -22,12 +22,12 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>639/639</span>
+        <span class='fraction'>643/643</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>349/349</span>
+        <span class='fraction'>351/351</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
@@ -37,7 +37,7 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>628/628</span>
+        <span class='fraction'>631/631</span>
       </div>
       <div class='fl pad1y'>
         <span class="strong">3 statements, 1 function, 8 branches</span>
@@ -66,13 +66,13 @@ <h1>
 	<td class="file high" data-value="index.c.js"><a href="index.c.js.html">index.c.js</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="639" class="abs high">639/639</td>
+	<td data-value="643" class="abs high">643/643</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="349" class="abs high">349/349</td>
+	<td data-value="351" class="abs high">351/351</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="100" class="abs high">100/100</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="628" class="abs high">628/628</td>
+	<td data-value="631" class="abs high">631/631</td>
 	</tr>
 
 </tbody>
@@ -81,7 +81,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Apr 07 2018 18:37:05 GMT+0200 (CEST)
+  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Apr 11 2018 17:51:36 GMT+0200 (CEST)
 </div>
 </div>
 <script src="../prettify.js"></script>

coverage/lcov-report/hyperHTML/index.c.js.html

@@ -22,12 +22,12 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>639/639</span>
+        <span class='fraction'>643/643</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>349/349</span>
+        <span class='fraction'>351/351</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
@@ -37,7 +37,7 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>628/628</span>
+        <span class='fraction'>631/631</span>
       </div>
       <div class='fl pad1y'>
         <span class="strong">3 statements, 1 function, 8 branches</span>
@@ -66,13 +66,13 @@ <h1>
 	<td class="file high" data-value="hyperHTML/"><a href="hyperHTML/index.html">hyperHTML/</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="639" class="abs high">639/639</td>
+	<td data-value="643" class="abs high">643/643</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="349" class="abs high">349/349</td>
+	<td data-value="351" class="abs high">351/351</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="100" class="abs high">100/100</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="628" class="abs high">628/628</td>
+	<td data-value="631" class="abs high">631/631</td>
 	</tr>
 
 </tbody>
@@ -81,7 +81,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Apr 07 2018 18:37:05 GMT+0200 (CEST)
+  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Apr 11 2018 17:51:36 GMT+0200 (CEST)
 </div>
 </div>
 <script src="prettify.js"></script>