Forbid wildcard imports

Needs to be implemented as an throwing custom step as Spotless doesn't have built in support to remove/deny wildcards: diffplug/spotless#649

Signed-off-by: Thomas Farr <[email protected]>

Author: Xtansia

java-client/build.gradle.kts

@@ -321,6 +321,16 @@ spotless {
 
         trimTrailingWhitespace()
         endWithNewline()
+
+        val wildcardImportRegex = Regex("""^import\s+(?:static\s+)?[^*\s]+\.\*;$""", RegexOption.MULTILINE)
+        custom("Refuse wildcard imports") { contents ->
+            // Wildcard imports can't be resolved by spotless itself.
+            // This will require the developer themselves to adhere to best practices.
+            if (wildcardImportRegex.containsMatchIn(contents)) {
+                throw AssertionError("Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.")
+            }
+            contents
+        }
     }
 }
 

java-codegen/build.gradle.kts

@@ -273,5 +273,15 @@ spotless {
 
         trimTrailingWhitespace()
         endWithNewline()
+
+        val wildcardImportRegex = Regex("""^import\s+(?:static\s+)?[^*\s]+\.\*;$""", RegexOption.MULTILINE)
+        custom("Refuse wildcard imports") { contents ->
+            // Wildcard imports can't be resolved by spotless itself.
+            // This will require the developer themselves to adhere to best practices.
+            if (wildcardImportRegex.containsMatchIn(contents)) {
+                throw AssertionError("Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.")
+            }
+            contents
+        }
     }
 }