coverage wat

Author: Aaron Loo

CONTRIBUTING.md

@@ -87,7 +87,7 @@ There are many examples of existing plugins to reference, under
 ### Tips
 
 - There should be a total of three modified files in a minimal new plugin: the
-  plugin file, it's corresponding code, and an updated README.
+  plugin file, it's corresponding test, and an updated README.
 - If your plugin uses customizable options (e.g. entropy limit in `HighEntropyStrings`)
   be sure to add default options to the plugin's `default_options`.
 

detect_secrets/plugins/common/util.py

@@ -15,8 +15,8 @@
 def get_mapping_from_secret_type_to_class_name():
     """Returns secret_type => plugin classname"""
     return {
-        value.secret_type: key
-        for key, value in import_plugins().items()
+        plugin.secret_type: name
+        for name, plugin in import_plugins().items()
     }
 
 

tests/pre_commit_hook_test.py

@@ -205,10 +205,8 @@ def test_baseline_gets_updated(
                 },
             ])
 
-            assert baseline_written['plugins_used'] == sorted(
-                regex_based_plugins,
-                key=lambda x: x['name'],
-            )
+            expected = sorted(regex_based_plugins, key=lambda x: x['name'])
+            assert baseline_written['plugins_used'] == expected
 
     def test_writes_new_baseline_if_modified(self):
         baseline_string = _create_baseline()