Skip to content

Commit 567a981

Browse files
authored
Merge pull request #25 from Yelp/24_fix_baseline_order
[baseline output] Add sort_keys=True to json.dumps
2 parents c567c47 + e15d0a9 commit 567a981

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

Diff for: detect_secrets/core/secrets_collection.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,11 @@ def json(self):
325325
return output
326326

327327
def __str__(self): # pragma: no cover
328-
return json.dumps(self.json(), indent=2)
328+
return json.dumps(
329+
self.json(),
330+
indent=2,
331+
sort_keys=True
332+
)
329333

330334
def __getitem__(self, key): # pragma: no cover
331335
return self.data[key]

Diff for: detect_secrets/main.py

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def main(argv=None):
3838
args.scan
3939
).format_for_baseline_output(),
4040
indent=2,
41+
sort_keys=True
4142
)
4243
)
4344

Diff for: detect_secrets/pre_commit_hook.py

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ def main(argv=None):
5858
json.dumps(
5959
baseline_collection.format_for_baseline_output(),
6060
indent=2,
61+
sort_keys=True
6162
)
6263
)
6364

Diff for: tests/pre_commit_hook_test.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -166,4 +166,8 @@ def _create_baseline():
166166
},
167167
}
168168

169-
return json.dumps(baseline, indent=2)
169+
return json.dumps(
170+
baseline,
171+
indent=2,
172+
sort_keys=True
173+
)

0 commit comments

Comments
 (0)