Skip to content

Commit f6bbd56

Browse files
zeroomegaZijunZhaoCCK
authored andcommitted
Revert "Update GoogleTest to v1.14.0 (llvm#65823)"
This reverts commit 54c1a9b. It breaks a few llvm bots.
1 parent f60c53d commit f6bbd56

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+13492
-11967
lines changed

clang/unittests/AST/ASTImporterODRStrategiesTest.cpp

-10
Original file line numberDiff line numberDiff line change
@@ -599,8 +599,6 @@ ASTIMPORTER_ODR_INSTANTIATE_TYPED_TEST_SUITE(
599599
INSTANTIATE_TEST_SUITE_P(
600600
ODRViolationTests, FunctionConservative,
601601
DefaultTestValuesForRunOptions );
602-
#else
603-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(FunctionConservative);
604602
#endif
605603
INSTANTIATE_TEST_SUITE_P(
606604
ODRViolationTests, TypedefConservative,
@@ -633,8 +631,6 @@ INSTANTIATE_TEST_SUITE_P(
633631
//INSTANTIATE_TEST_SUITE_P(
634632
//ODRViolationTests, VarTemplateConservative,
635633
//DefaultTestValuesForRunOptions);
636-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(VarTemplateConservative);
637-
638634
INSTANTIATE_TEST_SUITE_P(
639635
ODRViolationTests, FunctionTemplateSpecConservative,
640636
DefaultTestValuesForRunOptions);
@@ -645,15 +641,12 @@ INSTANTIATE_TEST_SUITE_P(
645641
//INSTANTIATE_TEST_SUITE_P(
646642
//ODRViolationTests, VarTemplateSpecConservative,
647643
//DefaultTestValuesForRunOptions);
648-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(VarTemplateSpecConservative);
649644

650645
// FIXME: These fail on Windows.
651646
#if !defined(_WIN32)
652647
INSTANTIATE_TEST_SUITE_P(
653648
ODRViolationTests, FunctionLiberal,
654649
DefaultTestValuesForRunOptions);
655-
#else
656-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(FunctionLiberal);
657650
#endif
658651
INSTANTIATE_TEST_SUITE_P(
659652
ODRViolationTests, TypedefLiberal,
@@ -686,8 +679,6 @@ INSTANTIATE_TEST_SUITE_P(
686679
// INSTANTIATE_TEST_SUITE_P(
687680
// ODRViolationTests, VarTemplateLiberal,
688681
// DefaultTestValuesForRunOptions);
689-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(VarTemplateLiberal);
690-
691682
INSTANTIATE_TEST_SUITE_P(
692683
ODRViolationTests, ClassTemplateSpecLiberal,
693684
DefaultTestValuesForRunOptions);
@@ -698,7 +689,6 @@ INSTANTIATE_TEST_SUITE_P(
698689
//INSTANTIATE_TEST_SUITE_P(
699690
//ODRViolationTests, VarTemplateSpecLiberal,
700691
//DefaultTestValuesForRunOptions );
701-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(VarTemplateSpecLiberal);
702692

703693
// clang-format on
704694

clang/unittests/AST/ASTImporterTest.cpp

-8
Original file line numberDiff line numberDiff line change
@@ -9227,13 +9227,5 @@ INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportAttributes,
92279227
INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportInjectedClassNameType,
92289228
DefaultTestValuesForRunOptions);
92299229

9230-
INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportMatrixType,
9231-
DefaultTestValuesForRunOptions);
9232-
9233-
// FIXME: Make ImportOpenCLPipe test work.
9234-
// INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportOpenCLPipe,
9235-
// DefaultTestValuesForRunOptions);
9236-
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(ImportOpenCLPipe);
9237-
92389230
} // end namespace ast_matchers
92399231
} // end namespace clang
+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
LLVM notes
22
----------
33

4-
This directory contains the 'googlemock' component of Google Test 1.14.0, with
4+
This directory contains the 'googlemock' component of Google Test 1.10.0, with
55
all elements removed except for the actual source code, to minimize the
66
addition to the LLVM distribution.
77

@@ -10,10 +10,14 @@ Cleaned up as follows:
1010
# Remove all the unnecessary files and directories
1111
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore
1212
$ rm -rf build-aux make msvc scripts test docs
13+
$ rm -f `find . -name \*\.pump`
1314
$ rm -f src/gmock_main.cc
1415

1516
# Put the license in the consistent place for LLVM.
1617
$ mv LICENSE LICENSE.TXT
1718

1819
Modified as follows:
1920
* Support for std::begin/std::end in gmock-matchers.h
21+
* IWYU pragmas
22+
* Disabled -Wdeprecated-copy for clang
23+
* Added IWYU pragmas from https://github.com/google/googletest/commit/100f6fbf5f81a82d163c1e29735e8a2936eacd4f

0 commit comments

Comments
 (0)