Skip to content

Commit 07a0022

Browse files
committed
Replace extra_fields by prepend_fields in queryset_to_xlsx_worksheet #1524
Signed-off-by: tdruez <[email protected]>
1 parent 16a2f3e commit 07a0022

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

scanpipe/pipes/output.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ def queryset_to_xlsx_worksheet(
308308
queryset,
309309
workbook,
310310
exclude_fields=None,
311-
extra_fields=None,
311+
prepend_fields=None,
312312
worksheet_name=None,
313313
):
314314
"""
@@ -328,10 +328,10 @@ def queryset_to_xlsx_worksheet(
328328

329329
fields = get_serializer_fields(model_class)
330330
exclude_fields = exclude_fields or []
331-
extra_fields = extra_fields or []
331+
prepend_fields = prepend_fields or []
332332
fields = [field for field in fields if field not in exclude_fields]
333-
if extra_fields:
334-
fields.extend(extra_fields)
333+
if prepend_fields:
334+
fields = prepend_fields + fields
335335

336336
return _add_xlsx_worksheet(
337337
workbook=workbook,

scanpipe/views.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def get_export_xlsx_queryset(self):
451451
def get_export_xlsx_filename(self):
452452
return f"{self.project.name}_{self.model._meta.model_name}.xlsx"
453453

454-
def get_export_xlsx_extra_fields(self):
454+
def get_export_xlsx_prepend_fields(self):
455455
return []
456456

457457
def get_export_xlsx_worksheet_name(self):
@@ -460,13 +460,13 @@ def get_export_xlsx_worksheet_name(self):
460460
def export_xlsx_file_response(self):
461461
output_file = io.BytesIO()
462462
queryset = self.get_export_xlsx_queryset()
463-
extra_fields = self.get_export_xlsx_extra_fields()
463+
prepend_fields = self.get_export_xlsx_prepend_fields()
464464
worksheet_name = self.get_export_xlsx_worksheet_name()
465465
with xlsxwriter.Workbook(output_file) as workbook:
466466
output.queryset_to_xlsx_worksheet(
467467
queryset,
468468
workbook,
469-
extra_fields=extra_fields,
469+
prepend_fields=prepend_fields,
470470
worksheet_name=worksheet_name,
471471
)
472472

@@ -1241,7 +1241,7 @@ def get_export_xlsx_queryset(self):
12411241
projects = self.get_projects_queryset()
12421242
return queryset.filter(project__in=projects)
12431243

1244-
def get_export_xlsx_extra_fields(self):
1244+
def get_export_xlsx_prepend_fields(self):
12451245
return ["project"]
12461246

12471247
def get_export_xlsx_worksheet_name(self):

0 commit comments

Comments
 (0)