Make review changes (Final Polish ;) )

Signed-off-by: Shivam Sandbhor <[email protected]>

Author: sbs2001

vulnerabilities/api.py

@@ -176,7 +176,6 @@ def bulk_search(self, request):
 
 
 class VulnerabilityFilterSet(filters.FilterSet):
-    vulnerability_id = filters.CharFilter(field_name="vulnerability_id")
 
     class Meta:
         model = Vulnerability

vulnerabilities/import_runner.py

@@ -118,7 +118,6 @@ def process_advisories(data_source: DataSource) -> None:
     # Treat updated_advisories and added_advisories as same. Eventually
     # we want to  refactor all data sources to  provide advisories via a
     # single method.
-    vulcoid_timestamp = datetime.datetime.now()
     advisory_batches = chain(data_source.updated_advisories(), data_source.added_advisories())
     for batch in advisory_batches:
         for advisory in batch:

vulnerabilities/models.py

@@ -44,7 +44,7 @@ class Vulnerability(models.Model):
 
     vulnerability_id = models.CharField(
         max_length=50,
-        help_text="Unique vulnerability_id for a vulnerability: this is either a published CVE id"
+        help_text="Unique identifier for a vulnerability: this is either a published CVE id"
         " (as in CVE-2020-7965) if it exists. Otherwise this is a VulnerableCode-assigned VULCOID"
         " (as in VULCOID-20210222-1315-16461541). When a vulnerability CVE is assigned later we"
         " replace this with the CVE and keep the 'old' VULCOID in the 'old_vulnerability_id'"
@@ -63,9 +63,8 @@ class Vulnerability(models.Model):
     )
 
     def save(self, *args, **kwargs):
-        if self.vulnerability_id:
-            return super().save(*args, **kwargs)
-        self.vulnerability_id = self.generate_vulcoid()
+        if not self.vulnerability_id:
+            self.vulnerability_id = self.generate_vulcoid()
         return super().save(*args, **kwargs)
 
     @staticmethod