Skip to content

Commit 74a455f

Browse files
committed
Merge branch 'PHP-8.3' into PHP-8.4
* PHP-8.3: fix phpGH-8533: dynamic libphp linking on Mac
2 parents d465449 + 009b5e2 commit 74a455f

File tree

4 files changed

+20
-1
lines changed

4 files changed

+20
-1
lines changed

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929
# Libtool library files generated during build process
3030
*.la
3131

32+
# Mac shared library files generated during build process
33+
*.dylib
34+
3235
# Directories created by Libtool for storing generated library files
3336
.libs/
3437

build/Makefile.global

+4
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ libphp.la: $(PHP_GLOBAL_OBJS) $(PHP_SAPI_OBJS)
1818
$(LIBTOOL) --tag=CC --mode=link $(CC) $(LIBPHP_CFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -rpath $(phptempdir) $(EXTRA_LDFLAGS) $(LDFLAGS) $(PHP_RPATHS) $(PHP_GLOBAL_OBJS) $(PHP_SAPI_OBJS) $(EXTRA_LIBS) $(ZEND_EXTRA_LIBS) -o $@
1919
-@$(LIBTOOL) --tag=CC --mode=install cp $@ $(phptempdir)/$@ >/dev/null 2>&1
2020

21+
libphp.dylib: libphp.la
22+
$(LIBTOOL) --tag=CC --mode=link $(CC) -dynamiclib $(LIBPHP_CFLAGS) $(CFLAGS_CLEAN) $(EXTRA_CFLAGS) -rpath $(phptempdir) -install_name @rpath/$@ $(EXTRA_LDFLAGS) $(LDFLAGS) $(PHP_RPATHS) $(PHP_GLOBAL_OBJS) $(PHP_SAPI_OBJS) $(EXTRA_LIBS) $(ZEND_EXTRA_LIBS) -o $@
23+
-@$(LIBTOOL) --silent --tag=CC --mode=install cp $@ $(phptempdir)/$@ >/dev/null 2>&1
24+
2125
libs/libphp.bundle: $(PHP_GLOBAL_OBJS) $(PHP_SAPI_OBJS)
2226
$(CC) $(MH_BUNDLE_FLAGS) $(CFLAGS_CLEAN) $(EXTRA_CFLAGS) $(LDFLAGS) $(EXTRA_LDFLAGS) $(PHP_GLOBAL_OBJS:.lo=.o) $(PHP_SAPI_OBJS:.lo=.o) $(PHP_FRAMEWORKS) $(EXTRA_LIBS) $(ZEND_EXTRA_LIBS) -o $@ && cp $@ libs/libphp.so
2327

build/php.m4

+9
Original file line numberDiff line numberDiff line change
@@ -779,6 +779,14 @@ AC_DEFUN([PHP_BUILD_SHARED],[
779779
php_lo=$shared_lo
780780
])
781781

782+
dnl
783+
dnl PHP_BUILD_SHARED_DYLIB
784+
dnl
785+
AC_DEFUN([PHP_BUILD_SHARED_DYLIB],[
786+
PHP_BUILD_SHARED
787+
OVERALL_TARGET=libphp.dylib
788+
])
789+
782790
dnl
783791
dnl PHP_BUILD_STATIC
784792
dnl
@@ -894,6 +902,7 @@ AC_DEFUN([PHP_SELECT_SAPI],[
894902
case "$2" in
895903
static[)] PHP_BUILD_STATIC;;
896904
shared[)] PHP_BUILD_SHARED;;
905+
shared-dylib[)] PHP_BUILD_SHARED_DYLIB;;
897906
bundle[)] PHP_BUILD_BUNDLE;;
898907
esac
899908
install_sapi="install-sapi"

sapi/embed/config.m4

+4-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ if test "$PHP_EMBED" != "no"; then
1111
AS_CASE([$PHP_EMBED],
1212
[yes|shared], [
1313
LIBPHP_CFLAGS="-shared"
14-
PHP_EMBED_TYPE=shared
14+
AS_CASE(["$host_alias"], [*darwin*], [
15+
SAPI_SHARED="libs/libphp.dylib"
16+
PHP_EMBED_TYPE=shared-dylib
17+
], [PHP_EMBED_TYPE=shared])
1518
INSTALL_IT="\$(mkinstalldirs) \$(INSTALL_ROOT)\$(orig_libdir); \$(INSTALL) -m 0755 $SAPI_SHARED \$(INSTALL_ROOT)\$(orig_libdir)"
1619
],
1720
[static], [

0 commit comments

Comments
 (0)