-
Notifications
You must be signed in to change notification settings - Fork 85
feat!: remove deprecated inputs #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
reviewed
Mar 29, 2025
096bd76
to
dd64f6e
Compare
gr2m
approved these changes
Apr 3, 2025
create-app-token-action-releaser bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
# [2.0.0](v1.12.0...v2.0.0) (2025-04-03) * feat!: remove deprecated inputs ([#213](#213)) ([5cc811b](5cc811b)) ### BREAKING CHANGES * Removed deprecated inputs (`app_id`, `private_key`, `skip_token_revoke`) and made `app-id` and `private-key` required in the action configuration.
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Yang-33
added a commit
to Yang-33/create-github-app-token
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed deprecated inputs (
app_id
,private_key
,skip_token_revoke
) and madeapp-id
andprivate-key
required in the action configuration.Updates to required fields and removal of deprecated inputs:
action.yml
: Madeapp-id
andprivate-key
required and removed the deprecatedapp_id
andprivate_key
inputs.main.js
: Updated the code to only useapp-id
andprivate-key
inputs, removing the fallback to deprecated inputs.skip_token_revoke
input.Test file updates:
tests/main-missing-app-id.test.js
: Removed the test case for missingapp-id
input as it is now required.tests/main-missing-private-key.test.js
: Removed the test case for missingprivate-key
input as it is now required.tests/snapshots/index.js.md
: Removed the snapshot entries related to deprecated inputs and updated the remaining snapshots accordingly. [1] [2] [3]