Skip to content

Releases #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anonrig opened this issue Jun 5, 2023 · 6 comments · Fixed by #16
Closed

Releases #15

anonrig opened this issue Jun 5, 2023 · 6 comments · Fixed by #16

Comments

@anonrig
Copy link
Member

anonrig commented Jun 5, 2023 •
edited
Loading

It seems we are not releasing a new version on pypi.org and github releases. Should we make the releases automatic just like Ada?

cc @bbayles
@bbayles
Copy link
Collaborator

bbayles commented Jun 5, 2023

I have it set up for some other projects, but I'm not entirely happy with it. I'll look into what improvements I can make here.

@bbayles
Copy link
Collaborator

bbayles commented Jun 5, 2023

The recent Trusted Publishers additions solve some of the problems I've seen before. I'll try them out.

@anonrig
Copy link
Member Author

anonrig commented Jun 5, 2023

The recent Trusted Publishers additions solve some of the problems I've seen before. I'll try them out.

Looks good! PS: I'm leaving for parental leave tomorrow, in case you need anything, please don't hesitate to contact @lemire

@bbayles bbayles mentioned this issue Jun 5, 2023
Merged
@bbayles bbayles linked a pull request Jun 5, 2023 that will close this issue
Publish to PyPI on release #16
Merged
@bbayles
Copy link
Collaborator

bbayles commented Jun 5, 2023

Congratulations! By coincidence, I will probably be starting parental leave next week.

@anonrig
Copy link
Member Author

anonrig commented Jun 5, 2023

Congratulations! By coincidence, I will probably be starting parental leave next week.

Congrats to you as well!

This was referenced Jun 5, 2023
Merged
Merged
@bbayles
Copy link
Collaborator

bbayles commented Jun 6, 2023

I think this will work for the next real release: this run failed, but only because I'd already uploaded a file with that name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish to PyPI on release ada-url/ada-python
2 participants
@bbayles @anonrig