Skip to content

MiniMQTT is losing legacy set_socket method #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justmobilize opened this issue Feb 24, 2024 · 1 comment
Closed

MiniMQTT is losing legacy set_socket method #62

justmobilize opened this issue Feb 24, 2024 · 1 comment

Comments

@justmobilize
Copy link
Contributor

Hello!

I am working through a project to simplify socket handling and unifying methods. This includes the removal of the set_socket methods that were originally designed around the wiznet5k and esp32spi.

This library calls set_socket in 2 places, which implies it supports the esp32spi, but in reality doesn't, since it also requires SSL.

I'm happy to update this library as it will soon become unusable and see three options:

  1. Fully remove esp32spi support. This is the easiest, since it's really just removing the legacy method, changing it to store the socketpool internally, and removing old docs and examples
  2. Add support for esp32spi, more work and testing, but not complicated as I've done this work elsewhere.
  3. Leave it be

Please let me know if I can help keep this library alive.

@justmobilize
Copy link
Contributor Author

Did 1.1 - added a note about ESP32SPI not currently working. PR here: #63

@justmobilize justmobilize changed the title MiniMQTT is loosing legacy set_socket method MiniMQTT is losing legacy set_socket method Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant