Skip to content

Commit 95d4771

Browse files
authored
Merge pull request #4 from dhalbert/defer-packet_size
defer creating buffers until MTU is known
2 parents fb8ffdc + 950776b commit 95d4771

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

adafruit_ble_cycling_speed_and_cadence.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,8 @@ class CyclingSpeedAndCadenceService(Service):
145145

146146
def __init__(self, service=None):
147147
super().__init__(service=service)
148-
self._measurement_buf = bytearray(
149-
self.csc_measurement.packet_size # pylint: disable=no-member
150-
)
148+
# Defer creating buffer until we're definitely connected.
149+
self._measurement_buf = None
151150

152151
@property
153152
def measurement_values(self):
@@ -169,6 +168,10 @@ def measurement_values(self):
169168
# uint16: Last Crank Event Time, in 1024ths of a second
170169
#
171170

171+
if self._measurement_buf is None:
172+
self._measurement_buf = bytearray(
173+
self.csc_measurement.incoming_packet_length # pylint: disable=no-member
174+
)
172175
buf = self._measurement_buf
173176
packet_length = self.csc_measurement.readinto(buf) # pylint: disable=no-member
174177
if packet_length == 0:

0 commit comments

Comments
 (0)