You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Super minor, but it shows up in my IDE when I use the stubs package. The third argument to the DS18X20 class constructor is named address and type hinted as an int. But right in the first line, it checks address.family_code. I think the type hint should be OneWireAddress. I could offer a minimal PR for this change if you agree, not sure if there's any CI testing for type hinting (I guess not because that probably would have been caught?).
Super minor, but it shows up in my IDE when I use the stubs package. The third argument to the DS18X20 class constructor is named
address
and type hinted as anint
. But right in the first line, it checksaddress.family_code
. I think the type hint should beOneWireAddress
. I could offer a minimal PR for this change if you agree, not sure if there's any CI testing for type hinting (I guess not because that probably would have been caught?).Adafruit_CircuitPython_DS18X20/adafruit_ds18x20.py
Lines 77 to 79 in a5c31cd
Anyway, thanks for this library and all your contributions to this ecosystem.
The text was updated successfully, but these errors were encountered: