Merge pull request #30 from orderthruchaos/join_paths_instead_of_concat

ladyada · web-flow · commit 0ac710c4c34e · 2020-12-20T12:34:01.000-05:00
Use `os.path.join` to concatenate paths
diff --git a/adafruit_slideshow.py b/adafruit_slideshow.py
@@ -244,11 +244,11 @@ def _check_json_file(file):
         # Load the image names before setting order so they can be reordered.
         self._img_start = None
         self._file_list = [
-            folder + f
+            os.path.join(folder, f)
             for f in os.listdir(folder)
             if (
                 not f.startswith(".")
-                and (f.endswith(".bmp") or _check_json_file(folder + f))
+                and (f.endswith(".bmp") or _check_json_file(os.path.join(folder, f)))
             )
         ]
 

Original file line number	Diff line number	Diff line change
`@@ -244,11 +244,11 @@ def _check_json_file(file):`
`244`	`244`	`# Load the image names before setting order so they can be reordered.`
`245`	`245`	`self._img_start = None`
`246`	`246`	`self._file_list = [`
`247`		`- folder + f`
	`247`	`+ os.path.join(folder, f)`
`248`	`248`	`for f in os.listdir(folder)`
`249`	`249`	`if (`
`250`	`250`	`not f.startswith(".")`
`251`		`- and (f.endswith(".bmp") or _check_json_file(folder + f))`
	`251`	`+ and (f.endswith(".bmp") or _check_json_file(os.path.join(folder, f)))`
`252`	`252`	`)`
`253`	`253`	`]`
`254`	`254`