Skip to content

Add font5x8.bin to Bundle #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tasm-Devil opened this issue Jan 30, 2019 · 7 comments
Closed

Add font5x8.bin to Bundle #11

Tasm-Devil opened this issue Jan 30, 2019 · 7 comments
Assignees

Comments

@Tasm-Devil
Copy link

Hi there!
I'm currently running the import examples.ssd1306_framebuftest in Circuitpython4 on a nrf52840 Express board.
I have to copy the font5x8.bin manually to the examples folder. Is it possible to add this font in the Adafruit_CircuitPython_Bundle and locate it by default in the font folder in the CIRCUITPY device?

@ladyada
Copy link
Member

ladyada commented Feb 3, 2019

@kattni i'm not sure how to do this but maybe you have an idea!

@kattni
Copy link
Contributor

kattni commented Feb 4, 2019

@Tasm-Devil I'm not entirely sure what you mean by "locate it by default in the font folder in the CIRCUITPY device".

The two options that seem reasonable are to have it added to the examples folder in the bundle, or to restructure the library to be a package and locate the font8x5.bin folder with the adafruit_framebuf.py module in the package folder.

As the file goes with the example, I think it makes the most sense to include it in the examples folder. This will involve updating circuitpython_build_tools to recognise and include the file. We're looking into what that means.

@ladyada Please let me know if including it in the examples folder in the bundle is sufficient.

@ladyada
Copy link
Member

ladyada commented Feb 4, 2019

i think having it copied into the examples folder would work best?

@kattni
Copy link
Contributor

kattni commented Feb 4, 2019

Ok. I'll talk to @sommersoft about it.

@sommersoft
Copy link
Collaborator

On it!

@sommersoft sommersoft self-assigned this Feb 5, 2019
@sommersoft
Copy link
Collaborator

Got it working locally.

(.env) sommersoft@thespacebetween:~/Dev/cpy-build-tools/circuitpython-build-tools/bundles$ unzip -l test-4.x-mpy-1475ae7.zip
Archive:  test-4.x-mpy-1475ae7.zip
{"build-tools-version": "devel"}
  Length      Date    Time    Name
---------  ---------- -----   ----
    1282  2019-02-04 21:49   test-4.x-mpy-1475ae7/examples/font5x8.bin
     997  2019-02-04 21:49   test-4.x-mpy-1475ae7/examples/framebuf_simpletest.py

@Tasm-Devil, give it a few days. Gotta push to the circuitpython-build-tools repo, then it will get pushed to PyPI, and then the Bundle will build with it included.

@sommersoft
Copy link
Collaborator

Just to follow up, font5x8.bin is now included in the examples folders with the bundle releases.

capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants