Skip to content

Commit 671bdea

Browse files
amit3srustyrussell
authored andcommitted
virtio: console: fix race in port_fops_open() and port unplug
Between open() being called and processed, the port can be unplugged. Check if this happened, and bail out. A simple test script to reproduce this is: while true; do for i in $(seq 1 100); do echo $i > /dev/vport0p3; done; done; This opens and closes the port a lot of times; unplugging the port while this is happening triggers the bug. CC: <[email protected]> Signed-off-by: Amit Shah <[email protected]> Signed-off-by: Rusty Russell <[email protected]>
1 parent 057b82b commit 671bdea

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/char/virtio_console.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,6 +1041,10 @@ static int port_fops_open(struct inode *inode, struct file *filp)
10411041

10421042
/* We get the port with a kref here */
10431043
port = find_port_by_devt(cdev->dev);
1044+
if (!port) {
1045+
/* Port was unplugged before we could proceed */
1046+
return -ENXIO;
1047+
}
10441048
filp->private_data = port;
10451049

10461050
/*

0 commit comments

Comments
 (0)