Skip to content

Commit 2c9772c

Browse files
committed
reordered the actions, so clang-format and doxygen are run first
This change reorders the actions so the least expensive and most failing actions are run first. On a typical run, doxygen and clang-format take each about 2s (plus 7s install), the complete building on all the supported platforms 10 minutes. In my experience, the most fails I get are from formatting and documentation errors, not from compilation problems. This gives the users a much faster feedback on needed changes in their commits and PRs and shaves off a lot of execution time.
1 parent d69421a commit 2c9772c

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

actions_install.sh

+1-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@ sudo apt-spy2 fix --commit
1010
# after selecting a specific mirror, we need to run 'apt-get update'
1111
sudo apt-get -o Acquire::Retries=3 update
1212

13-
sudo apt-get -o Acquire::Retries=3 install -y libllvm8 -V
14-
15-
sudo apt install -fy cppcheck clang-format-8
13+
sudo apt-get install -fy libllvm8 cppcheck clang-format-8
1614
if [ ! -f /usr/bin/clang-format ]; then
1715
sudo ln -s /usr/bin/clang-format-8 /usr/bin/clang-format
1816
fi

example_actions.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ jobs:
1919
- name: pre-install
2020
run: bash ci/actions_install.sh
2121

22-
- name: test platforms
23-
run: python3 ci/build_platform.py main_platforms
24-
2522
- name: clang
26-
run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r .
23+
run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r .
2724

2825
- name: doxygen
2926
env:
3027
GH_REPO_TOKEN: ${{ secrets.GH_REPO_TOKEN }}
3128
PRETTYNAME : "Adafruit Arduino Library"
3229
run: bash ci/doxy_gen_and_deploy.sh
30+
31+
- name: test platforms
32+
run: python3 ci/build_platform.py main_platforms

0 commit comments

Comments
 (0)