Use nvm to install Node in Dockerfile (swiftlang#788)

Author: adam-fowler

.nvmrc

@@ -0,0 +1 @@
+18.19.0

CONTRIBUTING.md

@@ -6,11 +6,15 @@ All contributors are expected to adhere to the project's [Code of Conduct](CODE_
 
 ## Development
 
-To begin development on the VSCode extension for Swift you will need to install [Node.js](https://nodejs.org). On Linux, make sure to install Node.js from its official website or from [NodeSource](https://github.com/nodesource/distributions/) as the version included with your Linux distribution may be outdated.
+To begin development on the VSCode extension for Swift you will need to install [Node.js](https://nodejs.org). We use [nvm](https://github.com/nvm-sh/nvm) the Node version manager to install Node.js. To install or update nvm you should run their install script
+```
+curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
+```
+More details on nvm installation can be found in the [README](https://github.com/nvm-sh/nvm/blob/master/README.md) from its GitHub repository.
 
-Next, clone this repository, and in the project directory run `npm install` to install all the dependencies.
+Once you have installed nvm, clone this repository, and in the project directory run `nvm install`. This will install the correct version of node.js for developing the extension. Then you should run `npm install` to install all the dependencies the extension requires.
 
-When you first open the project in VSCode you will be recommended to also install [`ESLint`](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint), [`Prettier - Code formatter`](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [`esbuild Problem Matchers`](https://marketplace.visualstudio.com/items?itemName=connor4312.esbuild-problem-matchers). Please do so. `ESLint`, `Prettier - Code formatter` are used to ensure a consistent style and expect everyone who contributes to follow this style as well. `esbuild Problem Matchers` provides proper error output from building the project.
+When you first open the project in VSCode you will be recommended to also install [`ESLint`](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint), [`Prettier - Code formatter`](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [`esbuild Problem Matchers`](https://marketplace.visualstudio.com/items?itemName=connor4312.esbuild-problem-matchers). Please do so. `ESLint`, `Prettier - Code formatter` is used to ensure a consistent style and we expect everyone who contributes to follow this style as well. `esbuild Problem Matchers` provides proper error output from building the project.
 
 To run your version of the Swift extension while in VSCode, press `F5`. This will open up another instance of VSCode with it running. You can use the original version of VSCode to debug it.
 

docker/Dockerfile

@@ -15,17 +15,18 @@ ENV LANGUAGE en_US.UTF-8
 # dependencies
 RUN apt-get update && apt-get install -y curl gpg libasound2 libgbm1 libgtk-3-0 libnss3 xvfb build-essential
 
-# install NodeJS 18
-# Add the NodeSource package signing key
-ENV KEYRING /usr/share/keyrings/nodesource.gpg
-RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | gpg --dearmor | tee "$KEYRING" >/dev/null
-RUN gpg --no-default-keyring --keyring "$KEYRING" --list-keys
-# Add the desired NodeSource repository
-ENV VERSION node_18.x
-ENV DISTRO $ubuntu_version
-RUN echo "deb [signed-by=$KEYRING] https://deb.nodesource.com/$VERSION $DISTRO main" | tee /etc/apt/sources.list.d/nodesource.list
-RUN echo "deb-src [signed-by=$KEYRING] https://deb.nodesource.com/$VERSION $DISTRO main" | tee -a /etc/apt/sources.list.d/nodesource.list
-# Update package lists and install Node.js
-RUN apt-get update && apt-get install -y nodejs
+RUN useradd --user-group --create-home --system --skel /dev/null --home-dir /vscode vscode
 
-RUN useradd --user-group --create-home --system --skel /dev/null --home-dir /vscode vscode
+RUN mkdir -p /usr/local/nvm
+RUN chown vscode /usr/local/nvm
+
+USER vscode
+ENV NVM_DIR /usr/local/nvm
+
+ENV NODE_VERSION v18.19.0
+RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
+RUN /bin/bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
+ENV NODE_PATH $NVM_DIR/versions/node/$NODE_VERSION/bin
+ENV PATH $NODE_PATH:$PATH
+RUN npm -v
+RUN node -v