Skip to content

Commit 9b74ec9

Browse files
committed
falcon: Drop support for Python 3.4
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
1 parent 07c52aa commit 9b74ec9

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

instrumentation/opentelemetry-instrumentation-falcon/setup.cfg

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,13 @@ classifiers =
2828
License :: OSI Approved :: Apache Software License
2929
Programming Language :: Python
3030
Programming Language :: Python :: 3
31-
Programming Language :: Python :: 3.4
3231
Programming Language :: Python :: 3.6
3332
Programming Language :: Python :: 3.7
3433
Programming Language :: Python :: 3.8
3534
Programming Language :: Python :: 3.9
3635

3736
[options]
38-
python_requires = >=3.4
37+
python_requires = >=3.6
3938
package_dir=
4039
=src
4140
packages=find_namespace:

tox.ini

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ envlist =
4646
pypy3-test-instrumentation-elasticsearch{2,5,6}
4747

4848
; opentelemetry-instrumentation-falcon
49-
py3{4,5,6,7,8,9}-test-instrumentation-falcon{2,3}
49+
py3{6,7,8,9}-test-instrumentation-falcon{2,3}
5050
pypy3-test-instrumentation-falcon{2,3}
5151

5252
; opentelemetry-instrumentation-fastapi
@@ -258,7 +258,7 @@ commands_pre =
258258
test: pip install "opentelemetry-semantic-conventions[test] @ {env:CORE_REPO}#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions"
259259
test: pip install "opentelemetry-sdk[test] @ {env:CORE_REPO}#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk"
260260
test: pip install "opentelemetry-test[test] @ {env:CORE_REPO}#egg=opentelemetry-test&subdirectory=tests/util"
261-
test: pip install {toxinidir}/opentelemetry-instrumentation
261+
test: pip install {toxinidir}/opentelemetry-instrumentation
262262

263263
distro: pip install {toxinidir}/opentelemetry-distro
264264

0 commit comments

Comments
 (0)