rename ThrowIfInvalid to Validate, fixes dotnet#1908

Author: adamsitnik

src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt

@@ -103,11 +103,11 @@ System.CommandLine
     public System.Boolean EnableTokenReplacement { get; }
     public LocalizationResources LocalizationResources { get; }
     public Command RootCommand { get; }
-    public System.Void ThrowIfInvalid()
   public class CommandLineConfigurationException : System.Exception, System.Runtime.Serialization.ISerializable
     .ctor(System.String message)
     .ctor()
     .ctor(System.String message, System.Exception innerException)
+    public System.Void Validate()
   public static class CompletionSourceExtensions
     public static System.Void Add(this CompletionSourceList completionSources, System.Func<System.CommandLine.Completions.CompletionContext,System.Collections.Generic.IEnumerable<System.String>> complete)
     public static System.Void Add(this CompletionSourceList completionSources, System.CommandLine.Completions.CompletionDelegate complete)

src/System.CommandLine.Tests/CommandLineConfigurationTests.cs

@@ -23,7 +23,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_option_aliases_
 
         var config = new CommandLineConfiguration(command);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -51,7 +51,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_option_aliases_
 
         var config = new CommandLineConfiguration(command);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -76,7 +76,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_subcommand_alia
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -104,7 +104,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_subcommand_alia
 
         var config = new CommandLineConfiguration(command);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -129,7 +129,7 @@ public void ThrowIfInvalid_throws_if_sibling_command_and_option_aliases_collide_
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -157,7 +157,7 @@ public void ThrowIfInvalid_throws_if_sibling_command_and_option_aliases_collide_
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -180,7 +180,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_global_option_a
 
         var config = new CommandLineConfiguration(command);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -204,7 +204,7 @@ public void ThrowIfInvalid_does_not_throw_if_global_option_alias_is_the_same_as_
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should().NotThrow();
     }
@@ -223,7 +223,7 @@ public void ThrowIfInvalid_does_not_throw_if_global_option_alias_is_the_same_as_
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should().NotThrow();
     }
@@ -236,7 +236,7 @@ public void ThrowIfInvalid_throws_if_a_command_is_its_own_parent()
 
         var config = new CommandLineConfiguration(command);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()
@@ -255,7 +255,7 @@ public void ThrowIfInvalid_throws_if_a_parentage_cycle_is_detected()
 
         var config = new CommandLineConfiguration(rootCommand);
 
-        var validate = () => config.ThrowIfInvalid();
+        var validate = () => config.Validate();
 
         validate.Should()
                 .Throw<CommandLineConfigurationException>()

src/System.CommandLine/CommandLineConfiguration.cs

@@ -118,7 +118,7 @@ private bool DefaultTokenReplacer(
         /// </summary>
         /// <remarks>Due to the performance cost of this method, it is recommended to be used in unit testing or in scenarios where the parser is configured dynamically at runtime.</remarks>
         /// <exception cref="CommandLineConfigurationException">Thrown if the configuration is found to be invalid.</exception>
-        public void ThrowIfInvalid()
+        public void Validate()
         {
             ThrowIfInvalid(RootCommand);