Add comment on time serialization fmt

Author: Daniel Jimenez

pkg/store/findings.go

@@ -969,7 +969,7 @@ func buildFindingExpanded(row map[string]interface{}) (FindingExpanded, error) {
 	if !ok {
 		return FindingExpanded{}, ErrParsingFinding
 	}
-	f.Source.Time = time // TODO: Which time format should we use?
+	f.Source.Time = time // Serialized to ISO8601 compliant format 2006-01-02T15:04:05Z
 
 	details, ok := row["details"].(string)
 	if !ok {

pkg/store/findings_test.go

@@ -292,37 +292,35 @@ func Test_buildFindingExposures(t *testing.T) {
 		{
 			name: "BuildsProperFindingExposuresWithMultiplePeriods",
 			sourceF: []sourceFindings{
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source1",
 					SourceTime:  mustParseTime("2019-04-10 20:40:56"),
 					Score:       intToFloatPtr(1),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source2",
 					SourceTime:  mustParseTime("2019-04-15 22:58:21"),
 					Score:       intToFloatPtr(2),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source3",
 					SourceTime:  mustParseTime("2019-05-08 23:46:36"),
 					Score:       intToFloatPtr(3),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding2"),
 					SourceID:    "source4",
 					SourceTime:  mustParseTime("2019-04-20 00:00:00"),
 					Score:       intToFloatPtr(1),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding3"),
 					SourceID:    "source5",
 					SourceTime:  mustParseTime("2019-06-08 20:47:08"),
@@ -332,46 +330,46 @@ func Test_buildFindingExposures(t *testing.T) {
 			},
 
 			wantFindingStates: []FindingState{
-				FindingState{
+				{
 					ID:          "finding1",
 					Status:      "FIXED",
 					Score:       3,
 					Fingerprint: FindingDefaultFingerprint,
 					Exposure: []FindingExposure{
-						FindingExposure{
+						{
 							FindingID: "finding1",
 							FoundAT:   mustParseTime("2019-04-10 20:40:56"),
 							FixedAT:   timeToPtr(mustParseTime("2019-04-20 00:00:00")),
 							TTR:       intToPtr(219),
 						},
-						FindingExposure{
+						{
 							FindingID: "finding1",
 							FoundAT:   mustParseTime("2019-05-08 23:46:36"),
 							FixedAT:   timeToPtr(mustParseTime("2019-06-08 20:47:08")),
 							TTR:       intToPtr(741),
 						},
 					},
 				},
-				FindingState{
+				{
 					ID:          "finding2",
 					Status:      "FIXED",
 					Score:       1,
 					Fingerprint: FindingDefaultFingerprint,
 					Exposure: []FindingExposure{
-						FindingExposure{
+						{
 							FindingID: "finding2",
 							FoundAT:   mustParseTime("2019-04-20 00:00:00"),
 							FixedAT:   timeToPtr(mustParseTime("2019-05-08 23:46:36")),
 							TTR:       intToPtr(455),
 						},
 					}},
-				FindingState{
+				{
 					ID:          "finding3",
 					Status:      "OPEN",
 					Score:       1,
 					Fingerprint: FindingDefaultFingerprint,
 					Exposure: []FindingExposure{
-						FindingExposure{
+						{
 							FindingID: "finding3",
 							FoundAT:   mustParseTime("2019-06-08 20:47:08"),
 						},
@@ -383,29 +381,28 @@ func Test_buildFindingExposures(t *testing.T) {
 		{
 			name: "BuildsProperFindingExposuresProperScoreAnsStatus",
 			sourceF: []sourceFindings{
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source1",
 					SourceTime:  mustParseTime("2019-04-10 20:40:56"),
 					Score:       intToFloatPtr(2),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source2",
 					SourceTime:  mustParseTime("2019-04-15 22:58:21"),
 					Score:       intToFloatPtr(2),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source3",
 					SourceTime:  mustParseTime("2019-05-08 23:46:36"),
 					Score:       intToFloatPtr(3),
 					Fingerprint: strToPtr(FindingDefaultFingerprint),
 				},
-
-				sourceFindings{
+				{
 					FindingID:   strToPtr("finding1"),
 					SourceID:    "source5",
 					SourceTime:  mustParseTime("2019-06-08 20:47:08"),
@@ -415,13 +412,13 @@ func Test_buildFindingExposures(t *testing.T) {
 			},
 
 			wantFindingStates: []FindingState{
-				FindingState{
+				{
 					ID:          "finding1",
 					Status:      "OPEN",
 					Score:       1,
 					Fingerprint: FindingDefaultFingerprint,
 					Exposure: []FindingExposure{
-						FindingExposure{
+						{
 							FindingID: "finding1",
 							FoundAT:   mustParseTime("2019-04-10 20:40:56"),
 						},