Skip to content

Commit 74638af

Browse files
committed
bump kubernetes-client to 6.10 (redhat-developer#713)
Signed-off-by: Andre Dietisheim <[email protected]>
1 parent 22c1d4d commit 74638af

File tree

7 files changed

+21
-18
lines changed

7 files changed

+21
-18
lines changed

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/resource/NamespacedResourceOperator.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ abstract class NamespacedResourceOperator<R : HasMetadata, C: Client>(
117117
client.adapt(KubernetesClient::class.java)
118118
.resource(toReplace)
119119
.inNamespace(inNamespace)
120-
.replace()
120+
.patch()
121121
}
122122
}
123123

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/resource/NonNamespacedResourceOperator.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ abstract class NonNamespacedResourceOperator<R : HasMetadata, C : Client>(
8787
return runWithoutServerSetProperties(toReplace) {
8888
client.adapt(KubernetesClient::class.java)
8989
.resource(toReplace)
90-
.replace()
90+
.patch()
9191
}
9292
}
9393

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/resource/kubernetes/custom/NamespacedCustomResourceOperator.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ open class NamespacedCustomResourceOperator(
8686
getOperation()
8787
?.inNamespace(inNamespace)
8888
?.resource(toReplace)
89-
?.createOrReplace()
89+
?.patch()
9090
}
9191
}
9292

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/resource/kubernetes/custom/NonNamespacedCustomResourceOperator.kt

+7-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ import io.fabric8.kubernetes.api.model.HasMetadata
1919
import io.fabric8.kubernetes.client.KubernetesClient
2020
import io.fabric8.kubernetes.client.Watch
2121
import io.fabric8.kubernetes.client.Watcher
22+
import io.fabric8.kubernetes.client.dsl.NonDeletingOperation
2223
import io.fabric8.kubernetes.client.dsl.base.CustomResourceDefinitionContext
24+
import io.fabric8.kubernetes.client.dsl.base.PatchContext
25+
import io.fabric8.kubernetes.client.dsl.base.PatchType
2326

2427
class NonNamespacedCustomResourceOperator(
2528
override val kind: ResourceKind<GenericKubernetesResource>,
@@ -72,7 +75,10 @@ class NonNamespacedCustomResourceOperator(
7275
return runWithoutServerSetProperties(toReplace) {
7376
getOperation()
7477
?.resource(resource)
75-
?.createOrReplace()
78+
/**
79+
* See: https://github.com/fabric8io/kubernetes-client/blob/main/doc/FAQ.md#alternatives-to-createOrReplace-and-replace
80+
*/
81+
?.patch()
7682
}
7783
}
7884

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/util/ResourceUtils.kt

+6-9
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinition
1616
import io.fabric8.kubernetes.client.utils.ApiVersionUtil
1717
import io.fabric8.kubernetes.client.utils.KubernetesVersionPriority
1818
import io.fabric8.kubernetes.client.utils.Serialization
19-
import io.fabric8.kubernetes.model.annotation.Group
20-
import io.fabric8.kubernetes.model.annotation.Version
21-
import io.fabric8.kubernetes.model.util.Helper
2219
import java.util.stream.Collectors
2320
import org.apache.tools.ant.util.ResourceUtils
2421

@@ -129,13 +126,13 @@ fun String.isGreaterIntThan(other: String?): Boolean {
129126
* @see io.fabric8.kubernetes.model.annotation.Group (annotation)
130127
*/
131128
fun getApiVersion(clazz: Class<out HasMetadata>): String {
132-
val apiVersion = Helper.getAnnotationValue(clazz, Version::class.java)
133-
return if (!apiVersion.isNullOrBlank()) {
134-
val apiGroup = Helper.getAnnotationValue(clazz, Group::class.java)
135-
if (!apiGroup.isNullOrBlank()) {
136-
getApiVersion(apiGroup, apiVersion)
129+
val version = HasMetadata.getVersion(clazz)
130+
return if (!version.isNullOrBlank()) {
131+
val group = HasMetadata.getGroup(clazz)
132+
if (!group.isNullOrBlank()) {
133+
getApiVersion(group, version)
137134
} else {
138-
apiVersion
135+
version
139136
}
140137
} else {
141138
clazz.simpleName

src/test/kotlin/com/redhat/devtools/intellij/kubernetes/model/mocks/ClientMocks.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,15 @@ object ClientMocks {
130130
) {
131131
val inNamespaceOp: Resource<HasMetadata> = mock {
132132
on { delete() } doReturn statusDetails
133-
on { replace() } doReturn resource
133+
on { patch() } doReturn resource
134134
on { create() } doReturn resource
135135
on { get() } doReturn resource
136136
}
137137
/** [KubernetesClient.resource] */
138138
val resourceOperation: NamespaceableResource<HasMetadata> = mock {
139139
on { inNamespace(any()) } doReturn inNamespaceOp
140140
on { delete() } doReturn statusDetails
141-
on { replace() } doReturn resource
141+
on { patch() } doReturn resource
142142
}
143143

144144
doReturn(resourceOperation)

src/test/kotlin/com/redhat/devtools/intellij/kubernetes/model/resource/kubernetes/NamespacedPodsOperatorTest.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ class NamespacedPodsOperatorTest {
381381
verify(client.get().adapt(KubernetesClient::class.java)
382382
.resource(toReplace)
383383
.inNamespace(toReplace.metadata.namespace))
384-
.replace()
384+
.patch()
385385
}
386386

387387
@Test
@@ -424,7 +424,7 @@ class NamespacedPodsOperatorTest {
424424
verify(client.get().adapt(KubernetesClient::class.java)
425425
.resource(toReplace)
426426
.inNamespace(toReplace.metadata.namespace))
427-
.replace()
427+
.patch()
428428
}
429429

430430
@Test
@@ -436,7 +436,7 @@ class NamespacedPodsOperatorTest {
436436
whenever(client.get().adapt(KubernetesClient::class.java)
437437
.resource(toReplace)
438438
.inNamespace(toReplace.metadata.namespace)
439-
.replace())
439+
.patch())
440440
.thenReturn(POD3)
441441
// when
442442
val newPod = operator.replace(toReplace)

0 commit comments

Comments
 (0)