Skip to content

Fix positioning of vac-room-header #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

thierbig
Copy link
Contributor

@thierbig thierbig commented Apr 22, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

N/A

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g., fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
    • Note: You should verify this by running the project's tests. If any tests fail because of this change, you may need to adjust them.

If adding a new feature, the PR's description includes:

  • N/A

Other information:

This PR addresses an issue where the .vac-room-header CSS property position: absolute; was causing layout problems by overlapping or obstructing other page elements, particularly static headers in user applications. By changing this to position: fixed;, the chat component's header will be more contained within the chat module itself, reducing the risk of it interfering with other UI components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants