-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] best_on_top
addition in plot_pairwise_scatter
#2655
[ENH] best_on_top
addition in plot_pairwise_scatter
#2655
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably longer than it has to be. just swap them around after the if statement if the parameter is false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loading the data again and classifier list seems unnecessary? Whole test is a bit weird
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
My bad on that. Made the necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Reference Issues/PRs
Fixes #2651
What does this implement/fix? Explain your changes.
The plot previously shows the better accuracy estimator on the y-axis (default). Added a parameter that can now show better accuracy estimator on x-axis when


best_on_top=False
.Better on y-axis
Better on x-axis
Also added a test in
test_plot_pairwise_scatter()