Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] best_on_top addition in plot_pairwise_scatter #2655

Merged
merged 7 commits into from
Apr 11, 2025

Conversation

aryanpola
Copy link
Contributor

Reference Issues/PRs

Fixes #2651

What does this implement/fix? Explain your changes.

The plot previously shows the better accuracy estimator on the y-axis (default). Added a parameter that can now show better accuracy estimator on x-axis when best_on_top=False.
Screenshot 2025-03-20 090040
Better on y-axis
Screenshot 2025-03-20 085944
Better on x-axis

Also added a test in test_plot_pairwise_scatter()

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement visualisation Visualisation module labels Mar 20, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#FBCA04}{\textsf{visualisation}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably longer than it has to be. just swap them around after the if statement if the parameter is false.

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading the data again and classifier list seems unnecessary? Whole test is a bit weird

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aryanpola
Copy link
Contributor Author

aryanpola commented Apr 5, 2025

Loading the data again and classifier list seems unnecessary? Whole test is a bit weird

My bad on that. Made the necessary changes.
Also added a case with best_on_top=False in the example notebook.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@TonyBagnall TonyBagnall merged commit 8b8783c into aeon-toolkit:main Apr 11, 2025
15 checks passed
@aryanpola aryanpola deleted the plot_pairwise_scatter branch April 12, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement visualisation Visualisation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] plot_pairwise_scatter select estimator position
3 participants