Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Refactor anomaly_detection into submodules #2663

Open
MatthewMiddlehurst opened this issue Mar 20, 2025 · 2 comments · May be fixed by #2694
Open

[REF] Refactor anomaly_detection into submodules #2663

MatthewMiddlehurst opened this issue Mar 20, 2025 · 2 comments · May be fixed by #2694
Assignees
Labels
anomaly detection Anomaly detection package refactor Restructuring without changing its external behavior

Comments

@MatthewMiddlehurst
Copy link
Member

MatthewMiddlehurst commented Mar 20, 2025

Describe the issue

Currently, all anomaly_detection estimators are in the top level module directory. We should separate them into submodules. The current proposal found through discussion in module meetings is separating by algorithm family (see https://dl.acm.org/doi/abs/10.14778/3538598.3538602 by @SebastianSchmidl, Table 1).

Including a few extras, this would give us:

Suggest a potential alternative/fix

Categorise current estimators and refactor the code in the module.

Additional context

Discussed in an anomaly detection module meeting. https://hackmd.io/@aeon-toolkit/HyZVExBZ1l

@MatthewMiddlehurst MatthewMiddlehurst added anomaly detection Anomaly detection package refactor Restructuring without changing its external behavior labels Mar 20, 2025
@Kaustbh
Copy link
Contributor

Kaustbh commented Mar 20, 2025

@aeon-actions-bot assign @Kaustbh

@Kaustbh
Copy link
Contributor

Kaustbh commented Mar 26, 2025

@KowshikB03 Thanks for your effort in addressing this issue. However, after reviewing your PR, I noticed that you created single estimator subfolder and moved all algorithms there. The intention, as mentioned in the issue, is to create different submodules/subfolders based on the categories outlined in the referenced paper.

@MatthewMiddlehurst I have categorized the estimators according to the suggested submodules. May I go ahead and create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection Anomaly detection package refactor Restructuring without changing its external behavior
Projects
None yet
2 participants