Skip to content

[MNT] lack of test cases covering all functionality for multiple regressors #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ramana-Raja opened this issue Mar 26, 2025 · 4 comments · May be fixed by #2693
Open

[MNT] lack of test cases covering all functionality for multiple regressors #2692

Ramana-Raja opened this issue Mar 26, 2025 · 4 comments · May be fixed by #2693
Labels
maintenance Continuous integration, unit testing & package distribution regression Regression package

Comments

@Ramana-Raja
Copy link
Contributor

Ramana-Raja commented Mar 26, 2025 •
edited
Loading

Describe the issue

many regressors, such as convolution-based and feature-based models, are missing test cases which actually test all the functionality of the regressors

Suggest a potential alternative/fix

it would be good to add test cases which cover up all functionality of the regressors

Additional context

No response
@Ramana-Raja Ramana-Raja linked a pull request Mar 26, 2025 that will close this issue
Draft
5 tasks
@MatthewMiddlehurst MatthewMiddlehurst added regression Regression package maintenance Continuous integration, unit testing & package distribution labels Mar 27, 2025
@MatthewMiddlehurst
Copy link
Member

This issue needs more detail. Every estimator is covered by the general testing.

@Ramana-Raja
Copy link
Contributor Author

This issue needs more detail. Every estimator is covered by the general testing.

I meant that there is a lack of test cases that check whether the tests actually generate correct or accurate outputs.For example,using ARI scores for clusterers etc, and also making sure the tests cover all functionality of regressors.

@MatthewMiddlehurst
Copy link
Member

Please edit the base issue. Also we do test expected output, so there is no need to test scores for the default parameters if the results are already stored.

@Ramana-Raja
Copy link
Contributor Author

Please edit the base issue. Also we do test expected output, so there is no need to test scores for the default parameters if the results are already stored.

Alright, understood. Do you have any suggestions on what else could be added to the test cases

@Ramana-Raja Ramana-Raja changed the title [ENH] lack of test cases for many regressors [ENH] lack of test cases covering all functionality for multiple regressors Mar 27, 2025
@Ramana-Raja Ramana-Raja changed the title [ENH] lack of test cases covering all functionality for multiple regressors lack of test cases covering all functionality for multiple regressors Mar 27, 2025
@Ramana-Raja Ramana-Raja changed the title lack of test cases covering all functionality for multiple regressors [MNT] lack of test cases covering all functionality for multiple regressors Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution regression Regression package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Added test cases for regressors Ramana-Raja/aeon
2 participants
@MatthewMiddlehurst @Ramana-Raja