[C] Fix thread handling on Windows (#864)

- A function with the wrong signature was being passed to CreateThread
 - The thread handle was never closed
 - Failure to start a thread was not detected

Author: ltrzesniewski

aeron-driver/src/main/c/aeron_agent.c

@@ -418,11 +418,7 @@ static void *agent_main(void *arg)
 {
     aeron_agent_runner_t *runner = (aeron_agent_runner_t *)arg;
 
-#if defined(Darwin)
     aeron_thread_set_name(runner->role_name);
-#else
-    aeron_thread_set_name(aeron_thread_self(), runner->role_name);
-#endif
 
     if (NULL != runner->on_start)
     {

aeron-driver/src/main/c/concurrent/aeron_thread.c

@@ -14,6 +14,11 @@
  * limitations under the License.
  */
 
+#if defined(__linux__)
+#define _BSD_SOURCE
+#define _GNU_SOURCE
+#endif
+
 #include "concurrent/aeron_thread.h"
 
 void aeron_nano_sleep(uint64_t nanoseconds)
@@ -42,6 +47,16 @@ void aeron_nano_sleep(uint64_t nanoseconds)
 }
 
 #if defined(AERON_COMPILER_GCC)
+
+void aeron_thread_set_name(const char* role_name)
+{
+#if defined(Darwin)
+    pthread_setname_np(role_name);
+#else
+    pthread_setname_np(pthread_self(), role_name);
+#endif
+}
+
 #elif defined(AERON_COMPILER_MSVC) && defined(AERON_CPU_X64)
 
 static BOOL aeron_thread_once_callback(PINIT_ONCE init_once, void (*callback)(void), void** context)
@@ -75,38 +90,62 @@ int aeron_thread_attr_init(pthread_attr_t* attr)
     return 0;
 }
 
+static DWORD WINAPI aeron_thread_proc(LPVOID parameter)
+{
+    aeron_thread_t* thread = (aeron_thread_t*)parameter;
+    thread->result = thread->callback(thread->arg0);
+    return 0;
+}
+
 int aeron_thread_create(aeron_thread_t* thread, void* attr, void*(*callback)(void*), void* arg0)
 {
+    thread->callback = callback;
+    thread->arg0 = arg0;
+	
     DWORD id;
-    *thread = CreateThread(
+    thread->handle = CreateThread(
         NULL,              // default security attributes
         0,                 // use default stack size
-        callback,          // thread function name
-        arg0,              // argument to thread function
+        aeron_thread_proc, // thread function name
+        thread,            // argument to thread function
         0,                 // use default creation flags
         &id);              // returns the thread identifier
 
-    return 0;
+    return thread->handle ? 0 : -1;
 }
 
-void aeron_thread_set_name(aeron_thread_t self, const char* role_name)
+void aeron_thread_set_name(const char* role_name)
 {
     size_t wn = mbstowcs(NULL, role_name, 0);
     wchar_t * buf = malloc(sizeof(wchar_t) * (wn + 1));  // value-initialize to 0 (see below)
+    if (!buf)
+    {
+        return;
+    }
+	
     mbstowcs(buf, role_name, wn + 1);
-    SetThreadDescription(self, buf);
+    SetThreadDescription(GetCurrentThread(), buf);
 
     free(buf);
 }
 
-aeron_thread_t aeron_thread_self()
+int aeron_thread_join(aeron_thread_t thread, void **value_ptr)
 {
-    return GetCurrentThread();
-}
+    if (thread.handle)
+    {
+        WaitForSingleObject(thread.handle, INFINITE);
+        CloseHandle(thread.handle);
+    }
+    else
+    {
+        return EINVAL;
+    }
+
+    if (value_ptr)
+    {
+        *value_ptr = thread.result;
+    }
 
-DWORD aeron_thread_join(aeron_thread_t thread, void **value_ptr)
-{
-    WaitForSingleObject(thread, INFINITE);
     return 0;
 }
 

aeron-driver/src/main/c/concurrent/aeron_thread.h

@@ -21,6 +21,7 @@
 
 #include <stdint.h>
 
+void aeron_thread_set_name(const char* role_name);
 
 #if defined(AERON_COMPILER_GCC)
 
@@ -36,8 +37,6 @@
     #define aeron_thread_once pthread_once
     #define aeron_thread_attr_init pthread_attr_init
     #define aeron_thread_create pthread_create
-    #define aeron_thread_set_name pthread_setname_np
-    #define aeron_thread_self pthread_self
     #define aeron_thread_join pthread_join
     #define aeron_thread_key_create pthread_key_create
     #define aeron_thread_key_delete pthread_key_delete
@@ -52,7 +51,13 @@
 
     #define AERON_MUTEX HANDLE
 
-    typedef HANDLE aeron_thread_t;
+    typedef struct
+    {
+        HANDLE handle;
+        void* (*callback)(void*);
+        void* arg0;
+        void* result;
+    } aeron_thread_t;
 
     typedef INIT_ONCE AERON_INIT_ONCE;
 
@@ -73,11 +78,7 @@
 
     int aeron_thread_create(aeron_thread_t* thread, void* attr, void*(*callback)(void*), void* arg0);
 
-    void aeron_thread_set_name(aeron_thread_t self, const char* role_name);
-
-    aeron_thread_t aeron_thread_self();
-
-    DWORD aeron_thread_join(aeron_thread_t thread, void **value_ptr);
+    int aeron_thread_join(aeron_thread_t thread, void **value_ptr);
 
     int aeron_thread_key_create(pthread_key_t *key, void(*destr_function) (void *));