@@ -733,9 +733,11 @@ func TestPipelineSpec_Validate_Failure_CycleDAG(t *testing.T) {
733
733
name := "invalid pipeline spec with DAG having cyclic dependency"
734
734
ps := & PipelineSpec {
735
735
Tasks : []PipelineTask {{
736
- Name : "foo" , TaskRef : & TaskRef {Name : "foo-task" }, RunAfter : []string {"bar " },
736
+ Name : "foo" , TaskRef : & TaskRef {Name : "foo-task" }, RunAfter : []string {"baz " },
737
737
}, {
738
738
Name : "bar" , TaskRef : & TaskRef {Name : "bar-task" }, RunAfter : []string {"foo" },
739
+ }, {
740
+ Name : "baz" , TaskRef : & TaskRef {Name : "baz-task" }, RunAfter : []string {"bar" },
739
741
}},
740
742
}
741
743
err := ps .Validate (context .Background ())
@@ -1139,9 +1141,15 @@ func TestValidateGraph_Failure(t *testing.T) {
1139
1141
}, {
1140
1142
Name : "bar" , TaskRef : & TaskRef {Name : "bar-task" }, RunAfter : []string {"foo" },
1141
1143
}}
1142
- if err := validateGraph (tasks ); err == nil {
1144
+ expectedError := apis.FieldError {
1145
+ Message : `invalid value: cycle detected; task "bar" depends on "foo"` ,
1146
+ Paths : []string {"tasks" },
1147
+ }
1148
+ err := validateGraph (tasks )
1149
+ if err == nil {
1143
1150
t .Error ("Pipeline.validateGraph() did not return error for invalid DAG of pipeline tasks:" , desc )
1144
-
1151
+ } else if d := cmp .Diff (expectedError .Error (), err .Error (), cmpopts .IgnoreUnexported (apis.FieldError {})); d != "" {
1152
+ t .Errorf ("Pipeline.validateGraph() errors diff %s" , diff .PrintWantGot (d ))
1145
1153
}
1146
1154
}
1147
1155
0 commit comments