Skip to content

Commit ff9b12f

Browse files
committed
remove image viewer - one could use GitHub os vs-code
1 parent 23ff879 commit ff9b12f

File tree

6 files changed

+0
-187
lines changed

6 files changed

+0
-187
lines changed

CONTRIBUTING.md

-18
Original file line numberDiff line numberDiff line change
@@ -229,24 +229,6 @@ Please note that image pixel comparison tests run using circleci/python:3.8.9 do
229229
Therefore the final baselines may need updates.
230230
This could simply be done by downloading the `baselines.tar` stored in the `ARTIFACTS` tab of `test-baselines` job (if the test failed).
231231

232-
### Image pixel comparison tests
233-
234-
Image pixel comparison tests are run in a docker container. For more
235-
information on how to run them locally, please refer to [image test
236-
README](https://github.com/plotly/plotly.js/blob/master/test/image/README.md).
237-
238-
Running the test locally outputs the generated png images in `build/test_images/` and the png diffs in `build/test_images_diff/` (two git-ignored directories).
239-
240-
To view the image pixel comparison test results, run
241-
242-
```
243-
npm run start-image_viewer
244-
```
245-
246-
which shows the baseline image, the generated image, the diff and the json mocks of test cases that failed.
247-
248-
To view the results of a run on CircleCI, download the `build/test_images/` and `build/test_images_diff/` artifacts into your local repo and then run `npm run start-image_viewer`.
249-
250232
### Using the developer console in karma to write/debug jasmine tests
251233

252234
- Click on the `DEBUG` button

devtools/image_viewer/index.html

-12
This file was deleted.

devtools/image_viewer/server.js

-51
This file was deleted.

devtools/image_viewer/viewer.js

-104
This file was deleted.

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"test-plain-obj": "node tasks/test_plain_obj.js",
4848
"test": "npm run test-jasmine -- --nowatch && npm run test-bundle && npm run test-image && npm run test-export && npm run test-syntax && npm run lint",
4949
"start-test_dashboard": "node devtools/test_dashboard/server.js",
50-
"start-image_viewer": "node devtools/image_viewer/server.js",
5150
"start": "npm run start-test_dashboard",
5251
"baseline": "node test/image/make_baseline.js",
5352
"noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",

tasks/util/constants.js

-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ module.exports = {
196196
pathToCSSBuild: path.join(pathToBuild, 'plotcss.js'),
197197

198198
pathToTestDashboardBundle: path.join(pathToBuild, 'test_dashboard-bundle.js'),
199-
pathToImageViewerBundle: path.join(pathToBuild, 'image_viewer-bundle.js'),
200199

201200
pathToImageTest: pathToImageTest,
202201
pathToTestImageMocks: path.join(pathToImageTest, 'mocks/'),

0 commit comments

Comments
 (0)