Skip to content

Commit e28d2f0

Browse files
authored
docs: split off a CONTRIBUTING.md and improve formatting, grammar, links (ezolenko#313)
* docs: split off a CONTRIBUTING.md from the README - condenses the README a bit and uses the standard CONTRIBUTING.md file - it's a file I often look for when filing an issue or creating a PR - leaves the section still in the README so that users (esp. on NPM) will know to go there if they're not aware of that convention - GitHub also now tells users to read the CONTRIBUTING.md of a repo when filing issues or creating PRs, so hopefully this helps point more users in the right direction as well * docs: improve formatting, grammar, and links in CONTRIBUTING.md - slightly change reference to GH Issue Tracker - use oxford commas everywhere for clarity - missing "the" in a few places - more minor grammatical fixes (missing space, semicolon vs. comma, etc) - fix: "npm_modules" -> "`node_modules`" - fix: "npm lint" -> "npm run lint", "npm build" -> "npm run build", "npm build-self" -> "npm run build-self" - short-hand works in Yarn and for some pre-defined Node scripts, like `start` and `test`, but the rest need `run` - "typescript" -> "TS" (prefer proper "TypeScript" or just "TS") - use backticks monospace/code formatting where appropriate - link to GitHub's official docs on forking and making PRs - also use the word "standard" instead of "normal" as it's more inclusive and reflective that this is a convention/standard - link to editorconfig site - link directly to `.editorconfig` with a relative link as well - reword portion about PR checks as they do run `build` and `build-self` nowadays (not sure how old this text is) - use an ordered list (instead of unordered) for the testing process as this is meant to be done in order
1 parent 895431d commit e28d2f0

File tree

2 files changed

+34
-28
lines changed

2 files changed

+34
-28
lines changed

CONTRIBUTING.md

+32
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# Contributing
2+
3+
## Reporting bugs
4+
5+
Report any bugs [in the GitHub Issue Tracker](https://github.com/ezolenko/rollup-plugin-typescript2/issues).
6+
7+
Attach your `tsconfig.json`, `package.json` (for versions of dependencies), `rollup.config.js`, and anything else that could influence module resolution, ambient types, and TS compilation.
8+
9+
Check if the problem is reproducible after running `npm prune` to clear any rogue types from `node_modules` (by default TS grabs _all_ ambient types).
10+
11+
Check if you get the same problem with `clean` option set to `true` (might indicate a bug in the cache).
12+
13+
If it makes sense, check if running `tsc` directly produces similar results.
14+
15+
Attach plugin output with `verbosity` option set to 3 (this will list all files being transpiled and their imports).
16+
17+
## Developing
18+
19+
Use the [standard GitHub process](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/about-collaborative-development-models#fork-and-pull-model) of forking, making a branch, and creating a PR when ready. Fix all linting problems (`npm run lint`) and fix any failed checks on the PR. Use an editor that supports [`editorconfig`](https://editorconfig.org/), or match the settings from [`.editorconfig`](./.editorconfig) manually.
20+
21+
Fastest way to test changes is to do a self build; the plugin is part of its own build system:
22+
23+
1. make changes
24+
1. run `npm run build` (uses last released version on npm)
25+
1. check that you get expected changes in `dist`
26+
1. run `npm run build-self` (uses fresh local build)
27+
1. check `dist` for the expected changes
28+
1. run `npm run build-self` _again_ to make sure plugin built by new version can still build itself
29+
30+
If `build-self` breaks at some point, fix the problem and restart from the `build` step (a known good copy).
31+
32+
This repo badly needs unit tests and integration tests with various scenarios and expected outcomes though.

README.md

+2-28
Original file line numberDiff line numberDiff line change
@@ -213,32 +213,6 @@ TypeScript `2.4+`
213213
Rollup `1.26.3+`
214214
Node `6.4.0+` (basic es6 support)
215215

216-
### Reporting bugs
216+
### Reporting bugs and Contributing
217217

218-
Report any bugs on github: <https://github.com/ezolenko/rollup-plugin-typescript2/issues>.
219-
220-
Attach your `tsconfig.json`, `package.json` (for versions of dependencies), rollup script and anything else that could influence module resolution, ambient types and typescript compilation.
221-
222-
Check if problem is reproducible after running `npm prune` to clear any rogue types from npm_modules (by default typescript grabs all ambient types).
223-
224-
Check if you get the same problem with `clean` option set to true (might indicate a bug in the cache).
225-
226-
If makes sense, check if running `tsc` directly produces similar results.
227-
228-
Attach plugin output with `verbosity` option set to 3 (this will list all files being transpiled and their imports).
229-
230-
### Contributing
231-
232-
Use the normal github process of forking, making a branch and creating a PR when ready. Fix all linting problems (run `npm lint`), fix any failed checks that are run on the PR (basically lint right now). Use an editor that supports editorconfig, or match the settings from `.editorconfig` file manually.
233-
234-
Fastest way to test changes is to do a self build, the plugin is part of its own build system:
235-
- make changes
236-
- run `npm build` (uses last released version on npm)
237-
- check that you get expected changes in `dist`
238-
- run `npm build-self` (uses fresh local build)
239-
- check `dist` for the expected changes
240-
- run `npm build-self` _again_ to make sure plugin built by new version can still build itself
241-
242-
If `build-self` breaks at some point, fix the problem and restart from `build` step (a known good copy).
243-
244-
This repo badly needs unittests and integration tests with various scenarios and expected outcomes though.
218+
See [CONTRIBUTING.md](./CONTRIBUTING.md)

0 commit comments

Comments
 (0)