gateway: unescape projectRef in commit status and run webhook deliveries api

* The projectRef must be unescaped in commit status and run webhook deliveries api.
* Add related tests.

Author: alessandro-sorint

Diff for: internal/services/gateway/api/commitstatusdelivery.go

@@ -16,6 +16,7 @@ package api
 
 import (
 	"net/http"
+	"net/url"
 
 	"github.com/gorilla/mux"
 	"github.com/rs/zerolog"
@@ -63,7 +64,10 @@ func (h *ProjectCommitStatusDeliveries) do(w http.ResponseWriter, r *http.Reques
 	query := r.URL.Query()
 
 	vars := mux.Vars(r)
-	projectRef := vars["projectref"]
+	projectRef, err := url.PathUnescape(vars["projectref"])
+	if err != nil {
+		return nil, util.NewAPIErrorWrap(util.ErrBadRequest, err)
+	}
 
 	ropts, err := parseRequestOptions(r)
 	if err != nil {
@@ -120,14 +124,17 @@ func (h *ProjectCommitStatusRedelivery) do(r *http.Request) error {
 	ctx := r.Context()
 
 	vars := mux.Vars(r)
-	projectRef := vars["projectref"]
+	projectRef, err := url.PathUnescape(vars["projectref"])
+	if err != nil {
+		return util.NewAPIErrorWrap(util.ErrBadRequest, err)
+	}
 	commitStatusDeliveryID := vars["commitstatusdeliveryid"]
 
 	areq := &action.ProjectCommitStatusRedeliveryRequest{
 		ProjectRef:             projectRef,
 		CommitStatusDeliveryID: commitStatusDeliveryID,
 	}
-	err := h.ah.ProjectCommitStatusRedelivery(ctx, areq)
+	err = h.ah.ProjectCommitStatusRedelivery(ctx, areq)
 	if err != nil {
 		return errors.WithStack(err)
 	}

Diff for: internal/services/gateway/api/runwebhookdelivery.go

@@ -16,6 +16,7 @@ package api
 
 import (
 	"net/http"
+	"net/url"
 
 	"github.com/gorilla/mux"
 	"github.com/rs/zerolog"
@@ -64,7 +65,10 @@ func (h *ProjectRunWebhookDeliveries) do(w http.ResponseWriter, r *http.Request)
 	query := r.URL.Query()
 
 	vars := mux.Vars(r)
-	projectRef := vars["projectref"]
+	projectRef, err := url.PathUnescape(vars["projectref"])
+	if err != nil {
+		return nil, util.NewAPIErrorWrap(util.ErrBadRequest, err)
+	}
 
 	ropts, err := parseRequestOptions(r)
 	if err != nil {
@@ -121,14 +125,17 @@ func (h *ProjectRunWebhookRedelivery) do(r *http.Request) error {
 	ctx := r.Context()
 
 	vars := mux.Vars(r)
-	projectRef := vars["projectref"]
+	projectRef, err := url.PathUnescape(vars["projectref"])
+	if err != nil {
+		return util.NewAPIErrorWrap(util.ErrBadRequest, err)
+	}
 	runWebhookDeliveryID := vars["runwebhookdeliveryid"]
 
 	areq := &action.ProjectRunWebhookRedeliveryRequest{
 		ProjectRef:           projectRef,
 		RunWebhookDeliveryID: runWebhookDeliveryID,
 	}
-	err := h.ah.ProjectRunWebhookRedelivery(ctx, areq)
+	err = h.ah.ProjectRunWebhookRedelivery(ctx, areq)
 	if err != nil {
 		return errors.WithStack(err)
 	}

Diff for: services/gateway/client/client.go

@@ -856,7 +856,7 @@ func (c *Client) GetProjectRunWebhookDeliveries(ctx context.Context, projectRef
 }
 
 func (c *Client) ProjectRunWebhookRedelivery(ctx context.Context, projectRef string, runWebhookDeliveryID string) (*Response, error) {
-	return c.getResponse(ctx, "PUT", fmt.Sprintf("/projects/%s/runwebhookdeliveries/%s/redelivery", projectRef, runWebhookDeliveryID), nil, jsonContent, nil)
+	return c.getResponse(ctx, "PUT", fmt.Sprintf("/projects/%s/runwebhookdeliveries/%s/redelivery", url.PathEscape(projectRef), runWebhookDeliveryID), nil, jsonContent, nil)
 }
 
 func (c *Client) GetProjectCommitStatusDeliveries(ctx context.Context, projectRef string, opts *DeliveriesOptions) ([]*gwapitypes.CommitStatusDeliveryResponse, *Response, error) {
@@ -869,5 +869,5 @@ func (c *Client) GetProjectCommitStatusDeliveries(ctx context.Context, projectRe
 }
 
 func (c *Client) ProjectCommitStatusRedelivery(ctx context.Context, projectRef string, commitStatusDeliveryID string) (*Response, error) {
-	return c.getResponse(ctx, "PUT", fmt.Sprintf("/projects/%s/commitstatusdeliveries/%s/redelivery", projectRef, commitStatusDeliveryID), nil, jsonContent, nil)
+	return c.getResponse(ctx, "PUT", fmt.Sprintf("/projects/%s/commitstatusdeliveries/%s/redelivery", url.PathEscape(projectRef), commitStatusDeliveryID), nil, jsonContent, nil)
 }