Merge pull request #534 from sgotti/explicitly_create_services_local_directories

*: explicitly create services local directories

Author: sgotti

internal/services/configstore/configstore.go

@@ -18,6 +18,8 @@ import (
 	"context"
 	"crypto/tls"
 	"net/http"
+	"os"
+	"path/filepath"
 	"sync"
 	"time"
 
@@ -89,6 +91,16 @@ func NewConfigstore(ctx context.Context, log zerolog.Logger, c *config.Configsto
 		log = log.Level(zerolog.DebugLevel)
 	}
 
+	if err := os.MkdirAll(c.DataDir, 0770); err != nil {
+		return nil, errors.WithStack(err)
+	}
+
+	if c.DB.Type == sql.Sqlite3 {
+		if err := os.MkdirAll(filepath.Dir(c.DB.ConnString), 0770); err != nil {
+			return nil, errors.WithStack(err)
+		}
+	}
+
 	ost, err := scommon.NewObjectStorage(ctx, &c.ObjectStorage)
 	if err != nil {
 		return nil, errors.WithStack(err)

internal/services/executor/executor.go

@@ -1434,6 +1434,10 @@ func NewExecutor(ctx context.Context, log zerolog.Logger, c *config.Executor) (*
 		},
 	}
 
+	if err := os.MkdirAll(c.DataDir, 0770); err != nil {
+		return nil, errors.WithStack(err)
+	}
+
 	if err := os.MkdirAll(e.tasksDir(), 0770); err != nil {
 		return nil, errors.WithStack(err)
 	}

internal/services/gitserver/main.go

@@ -132,6 +132,10 @@ func NewGitserver(ctx context.Context, log zerolog.Logger, c *config.Gitserver)
 		log = log.Level(zerolog.DebugLevel)
 	}
 
+	if err := os.MkdirAll(c.DataDir, 0770); err != nil {
+		return nil, errors.WithStack(err)
+	}
+
 	return &Gitserver{
 		log: log,
 		c:   c,

internal/services/notification/notification.go

@@ -18,6 +18,8 @@ import (
 	"context"
 	"crypto/tls"
 	"net/http"
+	"os"
+	"path/filepath"
 	"sync"
 	"time"
 
@@ -65,6 +67,12 @@ func NewNotificationService(ctx context.Context, log zerolog.Logger, gc *config.
 		log = log.Level(zerolog.DebugLevel)
 	}
 
+	if c.DB.Type == sql.Sqlite3 {
+		if err := os.MkdirAll(filepath.Dir(c.DB.ConnString), 0770); err != nil {
+			return nil, errors.WithStack(err)
+		}
+	}
+
 	sdb, err := sql.NewDB(c.DB.Type, c.DB.ConnString)
 	if err != nil {
 		return nil, errors.Wrapf(err, "new db error")

internal/services/runservice/runservice.go

@@ -18,6 +18,8 @@ import (
 	"context"
 	"crypto/tls"
 	"net/http"
+	"os"
+	"path/filepath"
 	"sync"
 	"time"
 
@@ -88,6 +90,16 @@ func NewRunservice(ctx context.Context, log zerolog.Logger, c *config.Runservice
 		log = log.Level(zerolog.DebugLevel)
 	}
 
+	if err := os.MkdirAll(c.DataDir, 0770); err != nil {
+		return nil, errors.WithStack(err)
+	}
+
+	if c.DB.Type == sql.Sqlite3 {
+		if err := os.MkdirAll(filepath.Dir(c.DB.ConnString), 0770); err != nil {
+			return nil, errors.WithStack(err)
+		}
+	}
+
 	ost, err := scommon.NewObjectStorage(ctx, &c.ObjectStorage)
 	if err != nil {
 		return nil, errors.WithStack(err)