[RFR] : some refactors

Author: aiekick

CMakeLists.txt

@@ -11,5 +11,5 @@ add_library(ImGuiFileDialog STATIC
 target_include_directories(ImGuiFileDialog PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 
 if(UNIX)
-    target_compile_options(ImGuiFileDialog PUBLIC "-Wno-unknown-pragmas")
+    target_compile_options(ImGuiFileDialog PUBLIC -Wno-unknown-pragmas)
 endif()

ImGuiFileDialog.cpp

@@ -792,14 +792,12 @@ class FileSystemDirent : public IGFD::IFileSystem {
 
 // https://github.com/ocornut/imgui/issues/1720
 bool IGFD::Utils::ImSplitter(bool split_vertically, float thickness, float* size1, float* size2, float min_size1, float min_size2, float splitter_long_axis_size) {
-    using namespace ImGui;
-    ImGuiContext& g     = *GImGui;
-    ImGuiWindow* window = g.CurrentWindow;
+    auto* window = ImGui::GetCurrentWindow();
     ImGuiID id          = window->GetID("##Splitter");
     ImRect bb;
     bb.Min = window->DC.CursorPos + (split_vertically ? ImVec2(*size1, 0.0f) : ImVec2(0.0f, *size1));
-    bb.Max = bb.Min + CalcItemSize(split_vertically ? ImVec2(thickness, splitter_long_axis_size) : ImVec2(splitter_long_axis_size, thickness), 0.0f, 0.0f);
-    return SplitterBehavior(bb, id, split_vertically ? ImGuiAxis_X : ImGuiAxis_Y, size1, size2, min_size1, min_size2, 1.0f, 0.0, ImGui::GetColorU32(ImGuiCol_FrameBg));
+    bb.Max = bb.Min + ImGui::CalcItemSize(split_vertically ? ImVec2(thickness, splitter_long_axis_size) : ImVec2(splitter_long_axis_size, thickness), 0.0f, 0.0f);
+    return ImGui::SplitterBehavior(bb, id, split_vertically ? ImGuiAxis_X : ImGuiAxis_Y, size1, size2, min_size1, min_size2, 1.0f, 0.0, ImGui::GetColorU32(ImGuiCol_FrameBg));
 }
 
 // Convert a wide Unicode string to an UTF8 string

ImGuiFileDialog.h

@@ -1,11 +1,5 @@
 #pragma once
 
-#if defined(__clang__)
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#elif defined(__GNUC__)
-#pragma GCC diagnostic ignored "-Wunknown-pragmas"
-#endif
-
 #ifdef _MSC_VER
 #pragma warning(disable : 4251)
 #endif