Skip to content

Commit 3367f82

Browse files
authored
fix(pypi): correctly pass extra_pip_args when building sdists (bazel-contrib#2368)
Before this change the `extra_pip_args` would not be passed down the chain if `experimental_index_url` is set. This adds a test and fixes the bug. Work towards bazel-contrib#260
1 parent 4dc0518 commit 3367f82

File tree

4 files changed

+464
-18
lines changed

4 files changed

+464
-18
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ A brief description of the categories of changes:
4545
`bzlmod` users would have observed.
4646
* (pypi) (Bazel 7.4+) Allow spaces in filenames included in `whl_library`s
4747
([617](https://github.com/bazelbuild/rules_python/issues/617)).
48+
* (pypi) When {attr}`pip.parse.experimental_index_url` is set, we need to still
49+
pass the `extra_pip_args` value when building an `sdist`.
4850

4951
{#v0-0-0-added}
5052
### Added

0 commit comments

Comments
 (0)