Skip to content

Commit 49dab88

Browse files
authored
Change import/no-self-import from "off" to "error"
We recently had an incident where this rule would have prevented infinite loops in Hypernova and in the browser.
1 parent 8247e33 commit 49dab88

File tree

1 file changed

+1
-2
lines changed
  • packages/eslint-config-airbnb-base/rules

1 file changed

+1
-2
lines changed

packages/eslint-config-airbnb-base/rules/imports.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,7 @@ module.exports = {
224224

225225
// Forbid a module from importing itself
226226
// https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
227-
// TODO: enable
228-
'import/no-self-import': 'off',
227+
'import/no-self-import': 'error',
229228

230229
// Ensures that there are no useless path segments
231230
// https://github.com/benmosher/eslint-plugin-import/issues/1032

0 commit comments

Comments
 (0)