Skip to content

Commit b4d8543

Browse files
committed
[eslint config] [react] [breaking] enable jsx-a11y rules:
- `jsx-a11y/heading-has-content` - `jsx-a11y/html-has-lang` - `jsx-a11y/lang` - `jsx-a11y/no-marquee` - `jsx-a11y/scope` - `jsx-a11y/href-no-hash` - `jsx-a11y/label-has-for`
1 parent a6da4bb commit b4d8543

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

packages/eslint-config-airbnb/rules/react-a11y.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ module.exports = {
2525
'jsx-a11y/aria-unsupported-elements': 2,
2626

2727
// disallow href "#"
28-
// TODO: enable
2928
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/href-no-hash.md
30-
'jsx-a11y/href-no-hash': [0, ['a']],
29+
'jsx-a11y/href-no-hash': [2, ['a']],
3130

3231
// Require <img> to have a non-empty `alt` prop, or role="presentation"
3332
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-has-alt.md
@@ -38,12 +37,11 @@ module.exports = {
3837
'jsx-a11y/img-redundant-alt': 2,
3938

4039
// require that JSX labels use "htmlFor"
41-
// TODO: enable
4240
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
43-
'jsx-a11y/label-has-for': [0, ['label']],
41+
'jsx-a11y/label-has-for': [2, ['label']],
4442

4543
// require that mouseover/out come with focus/blur, for keyboard-only users
46-
// TODO: enable?
44+
// TODO: evaluate
4745
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
4846
'jsx-a11y/mouse-events-have-key-events': 0,
4947

@@ -81,27 +79,22 @@ module.exports = {
8179

8280
// ensure <hX> tags have content and are not aria-hidden
8381
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
84-
// TODO: enable
85-
'jsx-a11y/heading-has-content': [0, ['']],
82+
'jsx-a11y/heading-has-content': [2, ['']],
8683

8784
// require HTML elements to have a "lang" prop
8885
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/html-has-lang.md
89-
// TODO: enable
90-
'jsx-a11y/html-has-lang': 0,
86+
'jsx-a11y/html-has-lang': 2,
9187

9288
// require HTML element's lang prop to be valid
9389
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
94-
// TODO: enable
95-
'jsx-a11y/lang': 0,
90+
'jsx-a11y/lang': 2,
9691

9792
// prevent marquee elements
9893
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-marquee.md
99-
// TODO: enable, pardner
100-
'jsx-a11y/no-marquee': 0,
94+
'jsx-a11y/no-marquee': 2,
10195

10296
// only allow <th> to have the "scope" attr
10397
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/scope.md
104-
// TODO: enable
105-
'jsx-a11y/scope': 0,
98+
'jsx-a11y/scope': 2,
10699
},
107100
};

0 commit comments

Comments
 (0)