Skip to content

Commit 6097f44

Browse files
committed
ArrayComparisonFailure serialization incompatibility fix:
Add back field fCause, initialize and use in the constructor (via initCause()) to avoid npe and unused field warnings, respectively Issue junit-team#1178, junit-team#976
1 parent 7f2569f commit 6097f44

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/main/java/org/junit/internal/ArrayComparisonFailure.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ public class ArrayComparisonFailure extends AssertionError {
1616

1717
/*
1818
* We have to use the f prefix until the next major release to ensure
19-
* serialization compatibility.
19+
* serialization compatibility.
2020
* See https://github.com/junit-team/junit4/issues/976
2121
*/
2222
private final List<Integer> fIndices = new ArrayList<Integer>();
2323
private final String fMessage;
24+
private final AssertionError fCause;
2425

2526
/**
2627
* Construct a new <code>ArrayComparisonFailure</code> with an error text and the array's
@@ -32,7 +33,8 @@ public class ArrayComparisonFailure extends AssertionError {
3233
*/
3334
public ArrayComparisonFailure(String message, AssertionError cause, int index) {
3435
this.fMessage = message;
35-
initCause(cause);
36+
this.fCause = cause;
37+
initCause(fCause);
3638
addDimension(index);
3739
}
3840

0 commit comments

Comments
 (0)