Skip to content

Commit 823fa02

Browse files
authored
Exceptions thrown by IUBundleContainer.cacheIUs are lost (eclipse-pde#127)
These exceptions are recorded by IUBundleContainer.synchronizerChanged but TargetDefinition.resolve(IProgressMonitor) only notices exceptions that are thrown and does not consider the status that recorded in the IContainerLocation. Logging is not needed because the exception was already logged when it was recorded. eclipse-pde#126
1 parent f1bb7c1 commit 823fa02

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetDefinition.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,10 @@ public IStatus resolve(IProgressMonitor monitor) {
402402
try {
403403
synchronizer.synchronize(this,
404404
subMonitor.split(synchronizerNumContainerMap.get(synchronizer).intValue() * 95));
405+
IStatus containerStatus = container.getStatus();
406+
if (containerStatus != null && !containerStatus.isOK()) {
407+
status.add(containerStatus);
408+
}
405409
} catch (CoreException e) {
406410
PDECore.log(e.getStatus());
407411
status.add(e.getStatus());

0 commit comments

Comments
 (0)