Don't set tags which are None

Michael Stella · Michael Stella · commit 1cbc87d389b0 · 2020-12-22T21:07:15.000-05:00
This is often `None`, but tags are always strings, and so things get broken when spans get passed along to other client calls. Fixes open-telemetry#262
diff --git a/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py b/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py
@@ -99,7 +99,7 @@ def inject(
             self.SAMPLING_PRIORITY_KEY,
             str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),
         )
-        if constants.DD_ORIGIN in span.context.trace_state:
+        if span.context.trace_state.get(constants.DD_ORIGIN):
             set_in_carrier(
                 carrier,
                 self.ORIGIN_KEY,

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ def inject(`
`99`	`99`	`self.SAMPLING_PRIORITY_KEY,`
`100`	`100`	`str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),`
`101`	`101`	`)`
`102`		`- if constants.DD_ORIGIN in span.context.trace_state:`
	`102`	`+ if span.context.trace_state.get(constants.DD_ORIGIN):`
`103`	`103`	`set_in_carrier(`
`104`	`104`	`carrier,`
`105`	`105`	`self.ORIGIN_KEY,`