Don't set tags which are None

Michael Stella · Michael Stella · commit 58c1673aa769 · 2021-03-02T09:54:40.000-05:00
This is often `None`, but tags are always strings, and so things get broken when spans get passed along to other client calls. Fixes open-telemetry#262
diff --git a/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py b/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py
@@ -97,7 +97,7 @@ def inject(
             self.SAMPLING_PRIORITY_KEY,
             str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),
         )
-        if constants.DD_ORIGIN in span.context.trace_state:
+        if span.context.trace_state.get(constants.DD_ORIGIN):
             set_in_carrier(
                 carrier,
                 self.ORIGIN_KEY,

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ def inject(`
`97`	`97`	`self.SAMPLING_PRIORITY_KEY,`
`98`	`98`	`str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),`
`99`	`99`	`)`
`100`		`- if constants.DD_ORIGIN in span.context.trace_state:`
	`100`	`+ if span.context.trace_state.get(constants.DD_ORIGIN):`
`101`	`101`	`set_in_carrier(`
`102`	`102`	`carrier,`
`103`	`103`	`self.ORIGIN_KEY,`