Don't set tags which are None

Michael Stella · Michael Stella · commit b31a71e0a4bf · 2021-04-14T14:07:37.000-04:00
This is often `None`, but tags are always strings, and so things get broken when spans get passed along to other client calls. Fixes open-telemetry#262
diff --git a/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py b/exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/propagator.py
@@ -103,7 +103,7 @@ def inject(
             self.SAMPLING_PRIORITY_KEY,
             str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),
         )
-        if constants.DD_ORIGIN in span.context.trace_state:
+        if span.context.trace_state.get(constants.DD_ORIGIN) is not None:
             setter.set(
                 carrier,
                 self.ORIGIN_KEY,

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ def inject(`
`103`	`103`	`self.SAMPLING_PRIORITY_KEY,`
`104`	`104`	`str(constants.AUTO_KEEP if sampled else constants.AUTO_REJECT),`
`105`	`105`	`)`
`106`		`- if constants.DD_ORIGIN in span.context.trace_state:`
	`106`	`+ if span.context.trace_state.get(constants.DD_ORIGIN) is not None:`
`107`	`107`	`setter.set(`
`108`	`108`	`carrier,`
`109`	`109`	`self.ORIGIN_KEY,`