Skip to content

Commit bcc53c8

Browse files
authored
Span.is_recording() now based off self._end_time and returns False if… (open-telemetry#1289)
1 parent f3cdfa2 commit bcc53c8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

opentelemetry-sdk/CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@
1010
([#998](https://github.com/open-telemetry/opentelemetry-python/pull/998))
1111
- Samplers to accept parent Context
1212
([#1267](https://github.com/open-telemetry/opentelemetry-python/pull/1267))
13-
- Updating status codes to adhere to spec ([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
13+
- Updating status codes to adhere to spec
14+
([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
15+
- Span.is_recording() returns false after span has ended
16+
([#1289](https://github.com/open-telemetry/opentelemetry-python/pull/1289))
1417

1518
## Version 0.14b0
1619

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ def update_name(self, name: str) -> None:
646646
self.name = name
647647

648648
def is_recording(self) -> bool:
649-
return True
649+
return self._end_time is None
650650

651651
@_check_span_ended
652652
def set_status(self, status: trace_api.Status) -> None:

0 commit comments

Comments
 (0)