Store ints as ints in the configuration object (open-telemetry#1119)

Fixes open-telemetry#1118

Co-authored-by: alrex <[email protected]>

Author: 2 people

Diff for: opentelemetry-api/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Store `int`s as `int`s in the global Configuration object
+  ([#1118](https://github.com/open-telemetry/opentelemetry-python/pull/1118))
+
 ## Version 0.13b0
 
 Released 2020-09-17

Diff for: opentelemetry-api/src/opentelemetry/configuration/__init__.py

@@ -128,11 +128,10 @@ def __new__(cls) -> "Configuration":
                         try:
                             value = int(value_str)
                         except ValueError:
-                            pass
-                        try:
-                            value = float(value_str)
-                        except ValueError:
-                            pass
+                            try:
+                                value = float(value_str)
+                            except ValueError:
+                                pass
 
                     instance._config_map[key] = value
 

Diff for: opentelemetry-api/tests/configuration/test_configuration.py

@@ -119,15 +119,12 @@ def test_boolean(self) -> None:
         },
     )
     def test_integer(self) -> None:
-        self.assertEqual(
-            Configuration().POSITIVE_INTEGER, 123
-        )  # pylint: disable=no-member
-        self.assertEqual(
-            Configuration().NEGATIVE_INTEGER, -123
-        )  # pylint: disable=no-member
-        self.assertEqual(
-            Configuration().NON_INTEGER, "-12z3"
-        )  # pylint: disable=no-member
+        # pylint: disable=no-member
+        self.assertIsInstance(Configuration().POSITIVE_INTEGER, int)
+        self.assertEqual(Configuration().POSITIVE_INTEGER, 123)
+        self.assertIsInstance(Configuration().NEGATIVE_INTEGER, int)
+        self.assertEqual(Configuration().NEGATIVE_INTEGER, -123)
+        self.assertEqual(Configuration().NON_INTEGER, "-12z3")
 
     @patch.dict(
         "os.environ",  # type: ignore