Skip to content

Commit 3b54c21

Browse files
author
Alexander Batashev
committed
[SYCL][NFC] Improve ABI testing for memory objects
intel#1870 broke ABI by adding new field to AccessorImplHost. This patch improves ABI testing to catch this type of problems in future. Signed-off-by: Alexander Batashev <[email protected]>
1 parent 13a1e49 commit 3b54c21

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

sycl/test/abi/symbol_size.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
#include <CL/sycl/accessor.hpp>
77
#include <CL/sycl/buffer.hpp>
8+
#include <CL/sycl/detail/accessor_impl.hpp>
9+
#include <CL/sycl/detail/buffer_impl.hpp>
10+
#include <CL/sycl/detail/image_impl.hpp>
811
#include <CL/sycl/device.hpp>
912
#include <CL/sycl/device_event.hpp>
1013
#include <CL/sycl/device_selector.hpp>
@@ -33,9 +36,16 @@ void check_size() {
3336

3437
int main() {
3538
using accessor_t = accessor<int, 1, access::mode::read,
36-
access::target::global_buffer, access::placeholder::true_t>;
39+
access::target::global_buffer,
40+
access::placeholder::true_t>;
3741
check_size<accessor_t, 32>();
42+
check_size<detail::AccessorImplDevice<1>, 24>();
43+
check_size<detail::LocalAccessorBaseDevice<1>, 24>();
44+
check_size<detail::AccessorImplHost, 128>();
45+
check_size<detail::AccessorBaseHost, 16>();
46+
check_size<detail::LocalAccessorImplHost, 56>();
3847
check_size<buffer<int>, 40>();
48+
check_size<detail::buffer_impl, 256>();
3949
check_size<context, 16>();
4050
check_size<cpu_selector, 8>();
4151
check_size<device, 16>();
@@ -49,6 +59,7 @@ int main() {
4959
check_size<handler, 560>();
5060
#endif
5161
check_size<image<1>, 16>();
62+
check_size<detail::image_impl<1>, 312>();
5263
check_size<kernel, 16>();
5364
check_size<platform, 16>();
5465
#ifdef __SYCL_DEVICE_ONLY__

0 commit comments

Comments
 (0)