compare to semgrep

Author: alexcoderabbitai

.github/workflows/dast.yml

@@ -1,18 +1,22 @@
----
-name: Linters
-
+name: Security Checks
 on:
-  workflow_dispatch:
   pull_request:
   push:
 
 jobs:
-  "dast-test":
-    runs-on: ubuntu-latest
-    container: python:3.11
-
-    steps:
-      - uses: actions/checkout@v2
-
-      - name: Install dependencies
-        run: cat results.sarif && exit 1
+    semgrep:
+        runs-on: ubuntu-latest
+        container:
+            image: returntocorp/semgrep:latest
+        steps:
+            - uses: actions/checkout@v4
+            
+            - name: Run Semgrep
+              env:
+                SEMGREP_RULES: >-
+                  p/security-audit
+                  p/owasp-top-ten
+                  p/javascript
+                  p/python
+              run: semgrep ci
+              

app.py

@@ -1 +1,67 @@
-foobar
+from flask import Flask, request, jsonify, Response
+import sqlite3
+
+app = Flask(__name__)
+
+# Database file
+DATABASE = 'app.db'
+
+def get_db_connection():
+    conn = sqlite3.connect(DATABASE)
+    return conn
+
+def init_db():
+    # Create table and insert data
+    conn = get_db_connection()
+    cursor = conn.cursor()
+    # Check if table already exists to prevent overwriting
+    cursor.execute("SELECT name FROM sqlite_master WHERE type='table' AND name='users';")
+    if cursor.fetchone() is None:
+        cursor.execute('CREATE TABLE users (id INTEGER PRIMARY KEY, name TEXT, age INTEGER);')
+        cursor.execute("INSERT INTO users (name, age) VALUES ('Alice', 30), ('Bob', 25), ('Charlie', 35);")
+        conn.commit()
+    conn.close()
+
+@app.route('/users', methods=['GET'])
+def get_user():
+    name = request.args.get('name')
+    conn = get_db_connection()
+    cursor = conn.cursor()
+
+    # Vulnerable SQL Query from raw string concatenation
+    query = f"SELECT * FROM users WHERE name = '{name}'"
+    cursor.execute(query)
+
+    # # Fixed SQL Query using parameterized queries
+    # query = "SELECT * FROM users WHERE name = ?"
+    # cursor.execute(query, (name,))
+    
+    user = cursor.fetchone()
+    conn.close()
+    if user:
+        return jsonify({"id": user[0], "name": user[1], "age": user[2]})
+    else:
+        return jsonify({"error": "User not found"}), 404
+
+@app.route('/.env', methods=['GET'])
+def get_env():
+    env_content = """
+DB_NAME=crapi
+DB_USER=crapi
+DB_PASSWORD=crapi
+DB_HOST=postgresdb
+DB_PORT=5432
+SERVER_PORT=8080
+MONGO_DB_HOST=mongodb
+MONGO_DB_PORT=27017
+MONGO_DB_USER=crapi
+MONGO_DB_PASSWORD=crapi
+MONGO_DB_NAME=crapi
+"""
+    return Response(env_content, headers={
+        "Content-Disposition": "attachment; filename=env"
+    })
+
+if __name__ == '__main__':
+    init_db()  # Initialize the database and populate it
+    app.run(host="0.0.0.0", debug=True)