Skip to content

Commit 16bfc19

Browse files
authored
Rollup merge of rust-lang#40347 - alexcrichton:rm-liblog, r=brson
Remove internal liblog This commit deletes the internal liblog in favor of the implementation that lives on crates.io. Similarly it's also setting a convention for adding crates to the compiler. The main restriction right now is that we want compiler implementation details to be unreachable from normal Rust code (e.g. requires a feature), and by default everything in the sysroot is reachable via `extern crate`. The proposal here is to require that crates pulled in have these lines in their `src/lib.rs`: #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))] This'll mean that by default they're not using these attributes but when compiled as part of the compiler they do a few things: * Mark themselves as entirely unstable via the `staged_api` feature and the `#![unstable]` attribute. * Allow usage of other unstable crates via `feature(rustc_private)` which is required if the crate relies on any other crates to compile (other than std).
2 parents 49c67bd + e341d60 commit 16bfc19

File tree

38 files changed

+54
-1194
lines changed

38 files changed

+54
-1194
lines changed

src/Cargo.lock

+21-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/liblog/Cargo.toml

-9
This file was deleted.

0 commit comments

Comments
 (0)